Merged
Conversation
Member
Author
|
The only blocker here is manual testing. I wanted to test this in |
Member
Author
|
I tested this in core. I did find some new errors from I think it's still fair to consider this non-breaking, since it's looser than the previous ruleset. But in practice it might end up being breaking because of disabled rules. |
Member
Author
|
I've updated the changelog to clarify that change, and explain why it's usually non-breaking but not always. |
Mrtenz
approved these changes
Nov 10, 2025
Merged
Gudahtt
added a commit
that referenced
this pull request
Nov 10, 2025
Reverts #411, which had a publishing failure. We will re-attempt after fixing the issue.
Merged
Gudahtt
added a commit
that referenced
this pull request
Nov 10, 2025
This is a re-attempt at release 14.1.0, originally attempted here: #411, but failed due to a worklfow bug that has now been fixed (in #420) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Publishes 14.1.0 across base, TypeScript, and Jest configs with TS 5.6–5.8 support and several rule relaxations/adjustments. > > - **Release `14.1.0`** > - Bump versions in `package.json` and packages (`@metamask/eslint-config`, `@metamask/eslint-config-typescript`, `@metamask/eslint-config-jest`). > - Update changelog links to new tags. > - **Base (`@metamask/eslint-config`)** > - Loosen `promise/catch-or-return` and `promise/param-names`. > - **TypeScript (`@metamask/eslint-config-typescript`)** > - Add support for TypeScript `5.6.x–5.8.x`. > - Disable `@typescript-eslint/no-unsafe-enum-comparison`. > - Loosen `@typescript-eslint/prefer-promise-reject-errors` (allow `unknown`). > - Loosen `@typescript-eslint/naming-convention` for import names. > - Loosen `@typescript-eslint/switch-exhaustiveness-check` to allow `default`. > - **Jest (`@metamask/eslint-config-jest`)** > - Replace `@typescript-eslint/unbound-method` with `jest/unbound-method` in tests. > - Remove `jest/no-conditional-in-test`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 590c1c4. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This release includes a few minor improvements across a few different packages.
Note
Publishes v14.1.0 across packages with TypeScript 5.6–5.8 support and several Jest/base ESLint rule adjustments.
14.1.0in root,@metamask/eslint-config,@metamask/eslint-config-jest, and@metamask/eslint-config-typescript.@metamask/eslint-config):promise/catch-or-returnandpromise/param-names.@metamask/eslint-config-jest):@typescript-eslint/unbound-methodwithjest/unbound-method.jest/no-conditional-in-test.@metamask/eslint-config-typescript):5.6.x–5.8.x.@typescript-eslint/no-unsafe-enum-comparison.@typescript-eslint/prefer-promise-reject-errors(allowunknown).@typescript-eslint/naming-convention(import names).@typescript-eslint/switch-exhaustiveness-check(allowdefault).Written by Cursor Bugbot for commit db61ab4. This will update automatically on new commits. Configure here.