BREAKING: Update jsdoc/require-jsdoc to require documentation for more things#394
Merged
BREAKING: Update jsdoc/require-jsdoc to require documentation for more things#394
jsdoc/require-jsdoc to require documentation for more things#394Conversation
Contributor
|
Nice, I didn't realize it was this easy! @Mrtenz Any place we've tried this out yet? If not I will try this out in |
Member
Author
@mcmire I've tried it in a small repo to make sure the rule works as expected, but I haven't tested it in I expect there will be a lot of lint errors since this is quite strict, but that's something we can gradually tackle. |
Gudahtt
approved these changes
Apr 17, 2025
Member
Gudahtt
left a comment
There was a problem hiding this comment.
LGTM! Maybe we should avoid merging this until after we cut a release for the non-breaking changes though
fa9cd15 to
e0efa13
Compare
Gudahtt
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the
jsdoc/require-jsdocrule to require documentation for:Arrow functions.
Class declarations.
TypeScript enum declarations.
Function expressions.
TypeScript interface declarations.
Method definitions.
TypeScript type alias declarations.
TypeScript property signatures.
Breaking changes
Each of the code blocks above was previously valid, but will now produce an error.
Closes #223.
Note
Expands
jsdoc/require-jsdocto require JSDoc on more JS/TS constructs and adds a brief doc comment toConfigWithExtends.extends.packages/base/src/index.mjs,packages/base/rules-snapshot.json):jsdoc/require-jsdocfrom a simple enablement to a configured rule requiring docs for:ArrowFunctionExpression,ClassDeclaration,FunctionDeclaration,FunctionExpression,MethodDefinition.TSInterfaceDeclaration,TSTypeAliasDeclaration,TSEnumDeclaration,TSPropertySignature.packages/base/src/index.d.mts):ConfigWithExtends.extendsdetailing supported shapes.Written by Cursor Bugbot for commit e0efa13. This will update automatically on new commits. Configure here.