Loosen @typescript-eslint/prefer-promise-reject-errors rule to allow rejecting with unknown

[Mrtenz]

This changes the @typescript-eslint/prefer-promise-reject-errors rule, which enforces that Promise.reject must be called with an instance of Error. After this change, reject may also be called with unknown values. For example, the following code was previously invalid, but is valid after this change:

new Promise((resolve, reject) => {
  try {
    return resolve(doSomething());
  } catch (error) {
    // `error` is of type `unknown`.
    return reject(error);
  }
});

[Gudahtt]

To clarify, are you saying that it's too strict because we'd be forced to verify that the error is an instance of Error?

Surely we're not intentionally throwing non-Errors. That's what I saw as the benefit of this rule - it's an additional check to ensure we're not throwing a non-Error.

If handling unknown is the only concern, there is an option for that: https://typescript-eslint.io/rules/prefer-promise-reject-errors/

[Mrtenz]

To clarify, are you saying that it's too strict because we'd be forced to verify that the error is an instance of Error?

Yes. It was causing a lot of errors in Snaps at least.

Surely we're not intentionally throwing non-Errors. That's what I saw as the benefit of this rule - it's an additional check to ensure we're not throwing a non-Error.

If handling unknown is the only concern, there is an option for that: https://typescript-eslint.io/rules/prefer-promise-reject-errors/

Good point. I wasn't aware of that option, that seems like a good alternative to completely disabling the rule.

[mcmire]

Makes sense!