Draft
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
mcmire
force-pushed
the
reorganize-src
branch
3 times, most recently
from
e058a38 to
803ad00
Compare
It's hard to tell how the UI code is using the code that was originally added for the CLI. This commit splits out common code into a `core/` directory while keeping the code unique to the CLI and UI in separate `cli/` and `ui/` directories.
mcmire
force-pushed
the
reorganize-src
branch
from
803ad00 to
65bc3b1
Compare
mcmire
commented
Dec 12, 2025
| export default defineConfig({ | ||
| plugins: [react(), tailwindcss()], | ||
| root: 'src/ui', | ||
| root: 'src/ui/app', |
Contributor
Author
There was a problem hiding this comment.
Pay particular attention to this. We want to make sure that these paths are correct and match what is being used in (what is now) ui/app/start.ts. (Note, I moved dist/ui to dist/ui/build so that the source for the app is in a different place than the compiled output.
Contributor
Author
There was a problem hiding this comment.
I moved this from src/, renamed it from dirname.ts, and changed it to return the "root" directory from the perspective of the source files (either src/ or dest/ depending on development or production).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's hard to tell how the UI code is using the code that was originally added for the CLI. This commit splits out common code into a
core/directory while keeping the code unique to the CLI and UI in separatecli/andui/directories.Manual testing steps
yarn build.coreto use the local version of this repo.create-release-branch. Test that it works as expected.create-release-branch -i. Test that it works as expected.