chore: Remove storage functionality from Delegation Controller#8330
Open
jeffsmale90 wants to merge 3 commits intomainfrom
Open
chore: Remove storage functionality from Delegation Controller#8330jeffsmale90 wants to merge 3 commits intomainfrom
jeffsmale90 wants to merge 3 commits intomainfrom
Conversation
bcb656a to
b21d0a3
Compare
b21d0a3 to
435164c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Delegation "storage" was added the the Delegation Controller to support Remote Mode. Because this feature is no longer in development, the storage functionality is not used.
This PR removes entirely the storage functionality from the controller.
Background
#8286 aimed to migrate code from clients into the controller, but as this storage functionality is unused, it was decided to remove the functionality completely. Followup PRs will be opened in the clients to update the controller, and remove the remaining boilerplate, including
awaitDeleteDelegationEntryfunction.Checklist
Note
Medium Risk
This is a breaking API change: it removes delegation persistence state and all related messenger methods/types, so downstream consumers may fail at compile/runtime until updated. Runtime risk is otherwise limited since signing behavior remains and storage logic is deleted rather than rewritten.
Overview
DelegationController is now signing-only. The controller no longer persists or exposes any
delegationsstate, and its state metadata/default state are reduced to an empty object.All storage-related APIs are removed:
store,list,retrieve,chain, anddeletemethods, their messenger method action types, and theDelegationEntry/DelegationFilterexports. This also drops the@metamask/accounts-controllerdependency and updates tests/docs/changelog to reflect the breaking removal.Written by Cursor Bugbot for commit 435164c. This will update automatically on new commits. Configure here.