feat(transaction-controller): add atomic option#8320
Draft
matthewwalsh0 wants to merge 1 commit intomainfrom
Draft
feat(transaction-controller): add atomic option#8320matthewwalsh0 wants to merge 1 commit intomainfrom
matthewwalsh0 wants to merge 1 commit intomainfrom
Conversation
c33cfe6 to
c68741e
Compare
c68741e to
6591450
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
The
addTransactionBatchmethod prioritises the EIP-7702 flow that uses ERC-7821 to execute batch transactions. Theexecutecall encodes amodebyte that controls atomicity — currently hardcoded to0x01(atomic), meaning all calls in the batch revert together if any single call fails.This PR makes the atomicity configurable via a new
atomicboolean onTransactionBatchRequest:atomic: true(default) — mode0x01, all calls revert together (existing behaviour, no breaking change)atomic: false— mode0x00, calls are independent and individual calls can fail without reverting the entire batchThe option flows from
TransactionBatchRequestthroughaddTransactionBatchWith7702intogenerateEIP7702BatchTransaction, which now accepts an optionaloptionsparameter. Callers that don't pass the option get the existing atomic behaviour.References
Checklist