fix: add missing @metamask/messenger dependency#8318
Open
cryptodev-2s wants to merge 5 commits intomainfrom
Open
fix: add missing @metamask/messenger dependency#8318cryptodev-2s wants to merge 5 commits intomainfrom
cryptodev-2s wants to merge 5 commits intomainfrom
Conversation
…-fee, and polling controllers
micaelae
previously approved these changes
Mar 26, 2026
mcmire
reviewed
Mar 26, 2026
Contributor
mcmire
left a comment
There was a problem hiding this comment.
A couple of things, but otherwise looks good to me.
micaelae
previously approved these changes
Mar 26, 2026
infiniteflower
previously approved these changes
Mar 26, 2026
a32f003
micaelae
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
bridge-status-controller,gas-fee-controller, andpolling-controllerimport from@metamask/messengerbut don't declare it in theirpackage.jsonor tsconfig references.This adds:
@metamask/messengeras a dependency tobridge-status-controllerandgas-fee-controller(used in production code)@metamask/messengeras a devDependency topolling-controller(only used in tests)bridge-status-controllerandgas-fee-controller(polling-controlleralready had them)References
N/A
Checklist
Note
Low Risk
Dependency-only changes to fix missing declared imports; low functional risk but may affect build/package graphs if version resolution differs across consumers.
Overview
Ensures packages that import
@metamask/messengeractually declare it: adds@metamask/messengeras a runtime dependency forbridge-status-controllerandgas-fee-controller, and as a devDependency forpolling-controller(tests).Updates
bridge-status-controllerandgas-fee-controllerTypeScript project references to include../messenger, and records the change in both packages’CHANGELOG.md(plusyarn.lockupdates).Written by Cursor Bugbot for commit a32f003. This will update automatically on new commits. Configure here.