Skip to content

fix: add missing @metamask/messenger dependency#8318

Open
cryptodev-2s wants to merge 5 commits intomainfrom
fix/add-missing-messenger-dependency
Open

fix: add missing @metamask/messenger dependency#8318
cryptodev-2s wants to merge 5 commits intomainfrom
fix/add-missing-messenger-dependency

Conversation

@cryptodev-2s
Copy link
Copy Markdown
Contributor

@cryptodev-2s cryptodev-2s commented Mar 26, 2026

Explanation

bridge-status-controller, gas-fee-controller, and polling-controller import from @metamask/messenger but don't declare it in their package.json or tsconfig references.

This adds:

  • @metamask/messenger as a dependency to bridge-status-controller and gas-fee-controller (used in production code)
  • @metamask/messenger as a devDependency to polling-controller (only used in tests)
  • Corresponding tsconfig references for bridge-status-controller and gas-fee-controller (polling-controller already had them)

References

N/A

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Low Risk
Dependency-only changes to fix missing declared imports; low functional risk but may affect build/package graphs if version resolution differs across consumers.

Overview
Ensures packages that import @metamask/messenger actually declare it: adds @metamask/messenger as a runtime dependency for bridge-status-controller and gas-fee-controller, and as a devDependency for polling-controller (tests).

Updates bridge-status-controller and gas-fee-controller TypeScript project references to include ../messenger, and records the change in both packages’ CHANGELOG.md (plus yarn.lock updates).

Written by Cursor Bugbot for commit a32f003. This will update automatically on new commits. Configure here.

@cryptodev-2s cryptodev-2s requested review from a team as code owners March 26, 2026 17:04
@cryptodev-2s cryptodev-2s self-assigned this Mar 26, 2026
@cryptodev-2s cryptodev-2s enabled auto-merge March 26, 2026 17:08
micaelae
micaelae previously approved these changes Mar 26, 2026
Copy link
Copy Markdown
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of things, but otherwise looks good to me.

@cryptodev-2s cryptodev-2s requested review from mcmire and micaelae March 26, 2026 18:03
micaelae
micaelae previously approved these changes Mar 26, 2026
infiniteflower
infiniteflower previously approved these changes Mar 26, 2026
mcmire
mcmire previously approved these changes Mar 26, 2026
Copy link
Copy Markdown
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants