Skip to content

chore: package config lint#110

Open
wenfix wants to merge 13 commits intomainfrom
chore/package-config-lint
Open

chore: package config lint#110
wenfix wants to merge 13 commits intomainfrom
chore/package-config-lint

Conversation

@wenfix
Copy link
Contributor

@wenfix wenfix commented Jan 14, 2026

Summary

This branch adds package configuration linting to the monorepo. It adds publint and @arethetypeswrong/cli as dev dependencies, creates lint:exports, lint:types, and lint:package-config scripts in the root package.json, and adds a pre-commit hook to run lint:package-config. All packages now include attw and publint scripts.

Some (benign) rules are being ignored per-package with the reasons detailed in the document included in this PR.

References

Fixes WAPI-925

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@socket-security
Copy link

socket-security bot commented Feb 5, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​arethetypeswrong/​cli@​0.18.210010010083100
Addedpublint@​0.2.121001009892100

View full report

@socket-security
Copy link

socket-security bot commented Feb 5, 2026

Warning

MetaMask internal reviewing guidelines:

  • Do not ignore-all
  • Each alert has instructions on how to review if you don't know what it means. If lost, ask your Security Liaison or the supply-chain group
  • Copy-paste ignore lines for specific packages or a group of one kind with a note on what research you did to deem it safe.
    @SocketSecurity ignore npm/PACKAGE@VERSION
Action Severity Alert  (click "▶" to expand/collapse)
Warn Low
Potential code anomaly (AI signal): npm glob is 100.0% likely to have a medium risk anomaly

Notes: The analyzed Glob library fragment implements standard, non-malicious filesystem globbing with proper asynchronous flow, error handling, and event emissions. It presents typical patterns for matching paths and optionally resolving real paths. Security risk is low to moderate as with any filesystem enumeration utility; no malicious activity detected in this fragment.

Confidence: 1.00

Severity: 0.60

From: ?npm/publint@0.2.12npm/glob@8.1.0

ℹ Read more on: This package | This alert | What is an AI-detected potential code anomaly?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: An AI system found a low-risk anomaly in this package. It may still be fine to use, but you should check that it is safe before proceeding.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/glob@8.1.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn Low
Potential code anomaly (AI signal): npm npm-bundled is 100.0% likely to have a medium risk anomaly

Notes: The analyzed fragment is a filesystem-based dependency walker that traverses node_modules to gather package information and package.json contents. There is no evidence of data exfiltration, remote control, or code execution. The primary concerns are silent error swallowing and potential path normalization gaps, but these do not indicate malicious intent. Overall risk is low to moderate depending on external consumption of the emitted data.

Confidence: 1.00

Severity: 0.60

From: ?npm/publint@0.2.12npm/npm-bundled@2.0.1

ℹ Read more on: This package | This alert | What is an AI-detected potential code anomaly?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: An AI system found a low-risk anomaly in this package. It may still be fine to use, but you should check that it is safe before proceeding.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/npm-bundled@2.0.1. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Ignoring alerts on:

  • @arethetypeswrong/core@0.18.2
  • npm-normalize-package-bin@2.0.0

View full report

@wenfix
Copy link
Contributor Author

wenfix commented Feb 5, 2026

@SocketSecurity ignore npm/@arethetypeswrong/core@0.18.2

Widely used package at ~400k weekly downloads.

Socket Security Analysis here

@wenfix
Copy link
Contributor Author

wenfix commented Feb 6, 2026

@SocketSecurity ignore npm/npm-normalize-package-bin@2.0.0

Luke Karrys is a reputable package maintainer.

@wenfix wenfix marked this pull request as ready for review February 6, 2026 15:19
@wenfix wenfix requested a review from a team as a code owner February 6, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant