Skip to content

feat(keyring-sdk): add encodeMnemonic#495

Merged
ccharly merged 3 commits intomainfrom
cc/feat/encode-mnemonic
Apr 1, 2026
Merged

feat(keyring-sdk): add encodeMnemonic#495
ccharly merged 3 commits intomainfrom
cc/feat/encode-mnemonic

Conversation

@ccharly
Copy link
Copy Markdown
Contributor

@ccharly ccharly commented Apr 1, 2026

Adding a small helper to encode from 16-bits indices to UTF-8 mnemonic string.

This will mostly be used by @metamask/eth-money-keyring integration.


Note

Low Risk
Low risk: adds a small, well-tested utility and a new dependency; main risk is incorrect wordlist/index handling or unexpected bundle/dependency impact.

Overview
Adds a new public helper, encodeMnemonic, to @metamask/keyring-sdk that converts a Uint8Array of 16-bit BIP-39 word indices into UTF-8 bytes for the corresponding English mnemonic phrase.

Exports the new module from src/index.ts, adds unit coverage for empty/single/multi-word cases, and introduces the @metamask/scure-bip39 dependency (with changelog and lockfile updates).

Written by Cursor Bugbot for commit 4611227. This will update automatically on new commits. Configure here.

@ccharly ccharly changed the title feat(keyring-sdk): add encodeMnemonic feat(keyring-sdk): add encodeMnemonic Apr 1, 2026
@ccharly ccharly marked this pull request as ready for review April 1, 2026 19:53
@ccharly ccharly requested a review from a team as a code owner April 1, 2026 19:53
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

@ccharly ccharly added this pull request to the merge queue Apr 1, 2026
Merged via the queue into main with commit 227bd89 Apr 1, 2026
39 checks passed
@ccharly ccharly deleted the cc/feat/encode-mnemonic branch April 1, 2026 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants