Merged
Conversation
encodeMnemonic
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
gantunesr
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adding a small helper to encode from 16-bits indices to UTF-8 mnemonic string.
This will mostly be used by
@metamask/eth-money-keyringintegration.Note
Low Risk
Low risk: adds a small, well-tested utility and a new dependency; main risk is incorrect wordlist/index handling or unexpected bundle/dependency impact.
Overview
Adds a new public helper,
encodeMnemonic, to@metamask/keyring-sdkthat converts aUint8Arrayof 16-bit BIP-39 word indices into UTF-8 bytes for the corresponding English mnemonic phrase.Exports the new module from
src/index.ts, adds unit coverage for empty/single/multi-word cases, and introduces the@metamask/scure-bip39dependency (with changelog and lockfile updates).Written by Cursor Bugbot for commit 4611227. This will update automatically on new commits. Configure here.