Skip to content

feat: add QR hardware wallet error mappings for extension#490

Merged
david0xd merged 4 commits intomainfrom
dd/add-qr-error-mappings
Mar 30, 2026
Merged

feat: add QR hardware wallet error mappings for extension#490
david0xd merged 4 commits intomainfrom
dd/add-qr-error-mappings

Conversation

@david0xd
Copy link
Copy Markdown
Contributor

@david0xd david0xd commented Mar 30, 2026

This PR adds QR hardware wallet error mappings (see change log and code changes).

Fixes: https://consensyssoftware.atlassian.net/browse/MUL-1446


Note

Low Risk
Additive enum/mapping/test updates only; primary risk is downstream consumers needing to handle the new ErrorCode value.

Overview
Adds QR hardware wallet–specific error handling by introducing QR_WALLET_ERROR_MAPPINGS with camera-permission states for extension QR scanning (prompt dismissed vs. browser-blocked).

Extends ErrorCode with PermissionCameraPromptDismissed, adds corresponding unit tests, and documents the addition in the changelog.

Written by Cursor Bugbot for commit a0902aa. This will update automatically on new commits. Configure here.

@david0xd david0xd self-assigned this Mar 30, 2026
@david0xd david0xd added the team-accounts This should be handled by the Accounts Team label Mar 30, 2026
@david0xd david0xd marked this pull request as ready for review March 30, 2026 13:17
@david0xd david0xd requested a review from a team as a code owner March 30, 2026 13:17
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

@david0xd david0xd changed the title feat: Add QR hardware wallet error mappings for extension Add QR hardware wallet error mappings for extension Mar 30, 2026
@david0xd david0xd changed the title Add QR hardware wallet error mappings for extension feat: add QR hardware wallet error mappings for extension Mar 30, 2026
@david0xd david0xd added this pull request to the merge queue Mar 30, 2026
Merged via the queue into main with commit b761789 Mar 30, 2026
39 of 40 checks passed
@david0xd david0xd deleted the dd/add-qr-error-mappings branch March 30, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-accounts This should be handled by the Accounts Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants