Open
Conversation
mathieuartu
reviewed
Dec 8, 2025
packages/keyring-internal-snap-client/src/v2/KeyringInternalSnapClientV2.ts
Outdated
Show resolved
Hide resolved
packages/keyring-internal-snap-client/src/v2/KeyringInternalSnapClientV2.ts
Outdated
Show resolved
Hide resolved
packages/keyring-internal-snap-client/src/v2/KeyringInternalSnapClientV2.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Mathieu Artu <mathieu.artu@gmail.com>
|
This PR is marked as stale because it has been open for 60 days with no activity. Please remove the stale label or leave a comment, or it will be closed in 14 days. |
25a340c to
eee7698
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Similar implementation than
KeyringClientbut using the new unified keyring API (keyring v2) methods.Note
Medium Risk
Introduces a new v2 JSON-RPC surface (including
exportAccount) across multiple packages, so any mismatch between request/response validation and Snap implementations could break integrations. Changes are mostly additive, but they touch request dispatching and account export flows which are sensitive to correctness.Overview
Adds keyring v2 JSON-RPC support end-to-end: new
KeyringRpcV2Methodenum plus typed request/response superstructs inkeyring-api, a newKeyringClientV2inkeyring-snap-clientthat sends/validates v2 RPC calls, and a newKeyringInternalSnapClientV2wrapper for communicating with Snaps via the controller messenger.Adds
keyring-snap-sdksupport viahandleKeyringRequestV2, which validates v2 requests and dispatches them toKeyringV2methods (with explicit handling for optionalexportAccount). Also tightensisKeyringRpcMethodto be a TS type predicate and includes new unit tests and changelog updates.Written by Cursor Bugbot for commit 0248be4. This will update automatically on new commits. Configure here.