Skip to content

feat: add KeyringClientV2 support#408

Open
ccharly wants to merge 32 commits intomainfrom
feat/keyring-client-v2
Open

feat: add KeyringClientV2 support#408
ccharly wants to merge 32 commits intomainfrom
feat/keyring-client-v2

Conversation

@ccharly
Copy link
Copy Markdown
Contributor

@ccharly ccharly commented Dec 4, 2025

Similar implementation than KeyringClient but using the new unified keyring API (keyring v2) methods.


Note

Medium Risk
Introduces a new v2 JSON-RPC surface (including exportAccount) across multiple packages, so any mismatch between request/response validation and Snap implementations could break integrations. Changes are mostly additive, but they touch request dispatching and account export flows which are sensitive to correctness.

Overview
Adds keyring v2 JSON-RPC support end-to-end: new KeyringRpcV2Method enum plus typed request/response superstructs in keyring-api, a new KeyringClientV2 in keyring-snap-client that sends/validates v2 RPC calls, and a new KeyringInternalSnapClientV2 wrapper for communicating with Snaps via the controller messenger.

Adds keyring-snap-sdk support via handleKeyringRequestV2, which validates v2 requests and dispatches them to KeyringV2 methods (with explicit handling for optional exportAccount). Also tightens isKeyringRpcMethod to be a TS type predicate and includes new unit tests and changelog updates.

Written by Cursor Bugbot for commit 0248be4. This will update automatically on new commits. Configure here.

@ccharly ccharly marked this pull request as ready for review December 5, 2025 15:02
@ccharly ccharly requested a review from a team as a code owner December 5, 2025 15:02
ccharly and others added 2 commits December 8, 2025 16:02
Co-authored-by: Mathieu Artu <mathieu.artu@gmail.com>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 7, 2026

This PR is marked as stale because it has been open for 60 days with no activity. Please remove the stale label or leave a comment, or it will be closed in 14 days.

@github-actions github-actions bot added the Stale label Mar 7, 2026
@ccharly ccharly force-pushed the feat/keyring-client-v2 branch from 25a340c to eee7698 Compare March 20, 2026 14:26
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

@github-actions github-actions bot removed the Stale label Mar 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants