Skip to content

Conversation

@zsinnema
Copy link
Contributor

@zsinnema zsinnema commented Sep 5, 2025

Closes CH-X

Sanity checks:

  • The pull request is explicitly linked to the relevant issue(s)
  • The issue is well described: clearly states the problem and the general proposed solution(s)
  • In this PR it is explicitly stated how to test the current change
  • The labels in the issue set the scope and the type of issue (bug, feature, etc.)
  • The relevant components are indicated in the issue (if any)
  • All the automated test checks are passing
  • All the linked issues are included in one Sprint
  • All the linked issues are in the Review state
  • All the linked issues are assigned

@zsinnema zsinnema requested a review from filippomc September 5, 2025 14:23
@zsinnema zsinnema changed the title chore(tilt): initial commit generate tilt file chore(tilt): generate tilt file Sep 5, 2025
Copy link
Collaborator

@filippomc filippomc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to integrate documentation on the presence of this functionality and how to use it.
Also why "chore" for a cool new functionality? :)

@@ -0,0 +1,24 @@
load('{{ch_root}}/deployment-configuration/tilt-deploy.ext', 'deploy')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency and flexibility, I'd move this to the deployment-configuration directory together with all other templates

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I first thought the same but then I realized it's not a deployment template but a "generate" tiltfile template
this one is used during running cloudharness-deploy (the generate command) and not during a deployment
therefore I think the current location is the best

@zsinnema zsinnema closed this Nov 27, 2025
@zsinnema zsinnema force-pushed the CH-217-generate-tiltfile branch from 2aa1f48 to 2509651 Compare November 27, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants