Skip to content

#742: allow variable lists to contain comments#756

Merged
Lauren Boon (mo-laurenboon) merged 3 commits intomainfrom
742_allow_prepare_ignore_comments
Jan 13, 2026
Merged

#742: allow variable lists to contain comments#756
Lauren Boon (mo-laurenboon) merged 3 commits intomainfrom
742_allow_prepare_ignore_comments

Conversation

@mo-laurenboon
Copy link
Copy Markdown
Collaborator

Closes issue #742.

Allows the variable lists in prepare to tolerate inline and single line comments that use '#' and blank lines within variable lists.

@mo-laurenboon Lauren Boon (mo-laurenboon) marked this pull request as ready for review December 22, 2025 11:26
@mo-laurenboon
Copy link
Copy Markdown
Collaborator Author

ATP

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small improvements worth looking at.

Comment thread cdds/cdds/prepare/generate.py
Comment thread cdds/cdds/tests/test_prepare/test_command_line.py Outdated
@mo-laurenboon Lauren Boon (mo-laurenboon) marked this pull request as draft January 6, 2026 15:31
@mo-laurenboon
Copy link
Copy Markdown
Collaborator Author

ATP

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mo-laurenboon Lauren Boon (mo-laurenboon) merged commit 3998a5c into main Jan 13, 2026
1 check passed
@mo-laurenboon Lauren Boon (mo-laurenboon) deleted the 742_allow_prepare_ignore_comments branch January 13, 2026 14:09
Ed (mo-gill) pushed a commit that referenced this pull request Jan 14, 2026
* #742: allow variable lists to contain comments

* #742: warn and remove whitespace within variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants