Skip to content

docs: Comprehensive documentation for PR #1763 features#491

Merged
MervinPraison merged 2 commits into
mainfrom
claude/issue-483-20260602-1856
Jun 3, 2026
Merged

docs: Comprehensive documentation for PR #1763 features#491
MervinPraison merged 2 commits into
mainfrom
claude/issue-483-20260602-1856

Conversation

@MervinPraison
Copy link
Copy Markdown
Owner

Summary

This PR implements comprehensive documentation updates for the architectural changes introduced in PraisonAI PR #1763, which included:

Sync/async SQLite split with new mode="sync"|"async"|"auto" parameter
Unified integration registry replacing manual __getattr__ ladder
Framework adapter resolve/setup methods for concrete variant selection and pre-run hooks
AutoGen version environment variable (AUTOGEN_VERSION) for automatic version resolution
Centralized observability hooks replacing inline AgentOps initialization

Changes Made

Updated Existing Pages (6)

  1. persistence-sqlite.mdx - Added sync/async decision tree, Quick Start examples, mode parameter docs, thread safety notes
  2. persistence/overview.mdx - Added sqlite_syncsync_sqlite alias and per-call locking info
  3. persistence-backend-plugins.mdx - Added sync_sqlite to primary backends and alias list
  4. framework-adapter-plugins.mdx - Documented new resolve() and setup() optional methods plus orchestrator pipeline
  5. framework/autogen.mdx - Added AUTOGEN_VERSION environment variable with auto-resolution table
  6. observability/agentops.mdx - Corrected "does not auto-init" statement and added observability hooks reference

New Pages Created (2)

  1. integration-registry.mdx - Complete documentation of the unified integration registry system with entry points
  2. observability-hooks.mdx - Centralized observability hook documentation for AgentOps and future providers

Navigation Updates

  • Added new pages to docs.json under Features/Integrations group
  • Maintained proper ordering near framework and persistence plugins

Technical Details

All changes strictly follow AGENTS.md guidelines:
• ✅ Pages placed in docs/features/ (never docs/concepts/)
• ✅ Mermaid diagrams use standard color palette (#8B0000, #189AB4, #10B981, #F59E0B, #6366F1)
• ✅ Copy-paste runnable code examples with correct imports
• ✅ Agent-centric Quick Start examples leading each page
• ✅ Mintlify components (Steps, AccordionGroup, CardGroup, Warning, Note, Info)
• ✅ Concise writing with progressive disclosure
• ✅ Valid JSON in docs.json

Closes

Fixes #483

🤖 Generated with Claude Code

- Add sync/async SQLite mode documentation with decision tree
- Document new AUTOGEN_VERSION environment variable
- Add framework adapter resolve() and setup() methods
- Correct AgentOps auto-init behavior documentation
- Create integration registry documentation
- Create observability hooks documentation
- Update backend aliases and navigation

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@qodo-code-review
Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 2, 2026

Warning

Review limit reached

@MervinPraison, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 51 minutes and 1 second. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0878609d-898a-4262-a8d4-f330e0e0cf36

📥 Commits

Reviewing files that changed from the base of the PR and between a80fbfb and 8623627.

📒 Files selected for processing (9)
  • docs.json
  • docs/features/framework-adapter-plugins.mdx
  • docs/features/integration-registry.mdx
  • docs/features/observability-hooks.mdx
  • docs/features/persistence-backend-plugins.mdx
  • docs/features/persistence-sqlite.mdx
  • docs/framework/autogen.mdx
  • docs/observability/agentops.mdx
  • docs/persistence/overview.mdx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/issue-483-20260602-1856

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation to reflect several new features and architectural changes, including the Integration Registry, Observability Hooks, sync/async SQLite persistence modes, and AutoGen version selection. The reviewer identified multiple critical discrepancies where the updated documentation does not match the actual codebase implementation. Specifically, the documentation describes orchestrator pipeline integrations (such as calling resolve, setup, and init_observability), centralized AgentOps initialization, and a refactored integrations dispatch that are not yet implemented in the code. Additionally, a warning regarding the removal of sync wrappers in AsyncSQLiteConversationStore is inaccurate as those wrappers remain present in the codebase.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +83 to +85
<Warning>
Before PR #1763, `AsyncSQLiteConversationStore` exposed sync wrappers like `get_session(...)` you could call from a regular function. Those wrappers were removed. If you were calling the async SQLite store from sync code, switch to `mode="sync"` (the new `sync_sqlite` backend) — it's purpose-built for that.
</Warning>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The warning states that the sync wrappers (like get_session(...)) were removed from AsyncSQLiteConversationStore. However, looking at praisonai/persistence/conversation/async_sqlite.py, these sync wrappers are still present and fully functional. This statement is inaccurate and contradicts the information in docs/persistence/overview.mdx which states that these sync wrappers are safe to call. Please update the warning to reflect that the sync wrappers are still available, or clarify the recommendation.


### Orchestrator Pipeline (Post-#1763)

The orchestrator (`AgentsGenerator.generate_crew_and_kickoff`) now follows this sequence:
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The sequence diagram and description state that AgentsGenerator.generate_crew_and_kickoff calls resolve(), init_observability(), and setup(). However, looking at the implementation of AgentsGenerator.generate_crew_and_kickoff in praisonai/agents_generator.py, these methods are not called. Instead, it directly initializes AgentOps inline and calls run() on the adapter. Please verify if the implementation matches this documentation or if the documentation needs to be updated to reflect the actual orchestrator pipeline.


`init_observability(framework_tag, *, tags=None)` centralizes observability initialization:

- **Auto-call site:** orchestrator calls `init_observability(adapter.name)` immediately after `assert_framework_available(...)` and before `adapter.setup(...)`
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This statement says that the orchestrator calls init_observability(adapter.name) immediately after assert_framework_available(...) and before adapter.setup(...). However, in praisonai/agents_generator.py, AgentsGenerator.generate_crew_and_kickoff does not call init_observability or setup. Instead, it uses inline AgentOps initialization. Please ensure the orchestrator implementation is aligned with this documentation.

Mod-->>User: MyIntegration
```

Before PR #1763, `praisonai/integrations/__init__.py` had a 70-line `if/elif` ladder in `__getattr__` that mapped attribute names to lazy imports. After #1763, the ladder is replaced by a 4-line dispatch backed by `INTEGRATIONS_REGISTRY`. The registry:
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The documentation states that the if/elif ladder in praisonai/integrations/__init__.py has been replaced by a 4-line dispatch backed by INTEGRATIONS_REGISTRY. However, in the codebase, praisonai/integrations/__init__.py still contains the 70-line if/elif ladder in __getattr__. Please verify if the code changes from PR #1763 are fully integrated or if the documentation needs to be adjusted.

- After every agent execution, the wrapper calls `agentops.end_session("Success")`. Failures are logged at `WARNING` level and never propagate.
- Detection happens once at module import via `importlib.util.find_spec("agentops")`. Installing `agentops` after the process started will not be picked up — restart the process.
- You still need to call `agentops.init(api_key=...)` yourself before starting an agent — PraisonAI does not auto-init.
- PraisonAI auto-inits AgentOps for you if `AGENTOPS_API_KEY` is set in the environment. The init is centralized in `praisonai.observability.hooks.init_observability(framework_tag, tags=...)` and is called automatically by the orchestrator before any adapter runs. You can call it yourself from a custom framework adapter's `setup()` hook if you need control over the tags.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This statement says that the initialization is centralized in praisonai.observability.hooks.init_observability(...) and called automatically by the orchestrator. However, in praisonai/agents_generator.py, the orchestrator still initializes AgentOps directly inline using agentops.init(...) and does not call init_observability. Please verify if the orchestrator changes are fully integrated or if this documentation needs to be updated.

@MervinPraison MervinPraison merged commit fe10d00 into main Jun 3, 2026
1 check was pending
@MervinPraison MervinPraison deleted the claude/issue-483-20260602-1856 branch June 3, 2026 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs needed for PR #1763: sync/async SQLite split, unified integration registry, adapter resolve/setup, AutoGen version env var

1 participant