Draft
Conversation
- Add partial_concentric_ellipse shape to infographics library - Introduce DonutArc extended object based on mxgraph.basic.partConcEllipse - Add implementation for DonutChart
Collaborator
|
This is gold! I love it. Definitely going to add the annotation-based approach to PieChart once this is merged! |
Collaborator
|
If there is one thing I could add to this, it would be the option to place the title either above (as in your examples) or in the middle of the donut (as this is something I see a lot, especially when having multiple DonutCharts alongside). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new DonutChart diagram type, built entirely from Object, Group, and a new DonutArc extended object, which is based on
mxgraph.basic.partConcEllipseinfographics shape.The design closely follows the conventions and workflow established by PieChart and BarChart, while extending them with annotation-based labeling for greater flexibility.
Annotation-based design
Instead of a single hard-coded label/value pair,
DonutChartuses annotations:INSIDEMIDDLEOUTSIDEThis design avoids label/value overlap issues and gives users full control over presentation without workarounds.
Few example usages
Labels inside, values in the middle
Labels and values in the middle
Labels outside, values middle
PR Roadmap
Before proceeding with development scripts, tests and documentation, I’d appreciate a review of the current implementation, especially the annotation based design (which can also be extended to existing pie chart implementation).