Skip to content

Add more information for the SSL erros #4278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gabriel-bolbotina wants to merge 4 commits into
base: master
Choose a base branch
from
+11 −0
Open

Add more information for the SSL erros #4278

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3bb5d46
Added ssl error logging in mergin api
gabriel-bolbotina Jan 8, 2026
6472932
Updated implementation
gabriel-bolbotina Jan 8, 2026
939d9a5
Implemented code findings
gabriel-bolbotina Jan 19, 2026
391e6f8
Formatted code
gabriel-bolbotina Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions core/merginapi.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,17 @@ MerginApi::MerginApi( LocalProjectsManager &localProjects, QObject *parent )
}
} );

#ifndef QT_NO_SSL
QObject::connect( mManager, &QNetworkAccessManager::sslErrors, this, []( QNetworkReply * reply, const QList<QSslError> &errors )
{
CoreUtils::log( "URL attempting to access:", reply->url().toString() );
for ( const auto &error : errors )
{
CoreUtils::log( "Error Description:", error.errorString() );
}
} );
Comment on lines +116 to +123
Copy link
Contributor

@Withalion Withalion Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
QObject::connect( mManager, &QNetworkAccessManager::sslErrors, this, []( QNetworkReply * reply, const QList<QSslError> &errors )
{
CoreUtils::log( "URL attempting to access:", reply->url().toString() );
for ( const auto &error : errors )
{
CoreUtils::log( "Error Description:", error.errorString() );
}
} );
QObject::connect( mManager, &QNetworkAccessManager::sslErrors, this, []( const QNetworkReply *reply, const QList<QSslError> &errors )
{
CoreUtils::log( QStringLiteral( "SSL error" ), QStringLiteral( "URL attempting to access: " ) + reply->url().toString() );
for ( const auto &error : errors )
{
CoreUtils::log( QStringLiteral( "SSL error" ), QStringLiteral( "Error Description:" ) + error.errorString() );
}
} );

#endif

//
// check if the cache is up to date:
// - server url and type
Expand Down
Loading