Fix autosync for related features

app/autosynccontroller.cpp

@@ -42,23 +42,18 @@ AutosyncController::AutosyncController(
     {
       if ( !vecLayer->readOnly() )
       {
-        connect( vecLayer, &QgsVectorLayer::afterCommitChanges, this, [&]
-        {
-          mLastUpdateTime = QDateTime::currentDateTime();
-          emit projectSyncRequested( SyncOptions::RequestOrigin::AutomaticRequest );
-        } );
+        connect( vecLayer, &QgsVectorLayer::afterCommitChanges, this, &AutosyncController::syncLayerChange );
       }
     }
   }
 
-  //every 10 seconds check if last sync was a 60 seconds or more ago and sync if it's true
+  //every 10 seconds check if last sync was 60 seconds or more ago and sync if it's true
   mTimer = std::make_unique<QTimer>( this );
   connect( mTimer.get(), &QTimer::timeout, this, [&]
   {
     if ( QDateTime::currentDateTime() - mLastUpdateTime >= std::chrono::milliseconds( SYNC_INTERVAL ) )
     {
-      mLastUpdateTime = QDateTime::currentDateTime();
-      emit projectSyncRequested( SyncOptions::RequestOrigin::AutomaticRequest );
+      syncLayerChange();
     }
   } );
   mTimer->start( SYNC_CHECK_TIMEOUT );
@@ -69,6 +64,15 @@ void AutosyncController::updateLastUpdateTime()
   mLastUpdateTime = QDateTime::currentDateTime();
 }
 
+void AutosyncController::syncLayerChange()
+{
+  if ( !mIsSyncPaused )
+  {
+    mLastUpdateTime = QDateTime::currentDateTime();
+    emit projectSyncRequested( SyncOptions::RequestOrigin::AutomaticRequest );
+  }
+}
+
 void AutosyncController::checkSyncRequiredAfterAppStateChange( const Qt::ApplicationState state )
 {
   if ( state != Qt::ApplicationState::ApplicationActive )

app/autosynccontroller.h

@@ -29,17 +29,26 @@ class AutosyncController : public QObject
     // Set mLastUpdateTime to "now", triggered by manual sync
     void updateLastUpdateTime();
 
+    Q_INVOKABLE void setIsSyncPaused( const bool isSyncPaused )
+    {
+      mIsSyncPaused = isSyncPaused;
+    }
+
+
   signals:
     void projectSyncRequested( SyncOptions::RequestOrigin origin );
 
   public slots:
     void checkSyncRequiredAfterAppStateChange( Qt::ApplicationState state );
+    // This triggers sync after a change has been saved to layer
+    Q_INVOKABLE void syncLayerChange();
 
   private:
 
     QgsProject *mQgsProject = nullptr; // not owned
     QDateTime mLastUpdateTime;
     std::unique_ptr<QTimer> mTimer = nullptr;
+    bool mIsSyncPaused = false;
 };
 
 #endif // AUTOSYNCCONTROLLER_H

app/qml/form/MMFormController.qml

@@ -40,6 +40,7 @@ Item {
   property real drawerHeight: drawer.height
 
   signal closed()
+  signal saveRequested()
   signal editGeometry( var pair )
   signal openLinkedFeature( var linkedFeature )
   signal createLinkedFeature( var targetLayer, var parentPair )
@@ -79,6 +80,7 @@ Item {
           StateChangeScript {
             script: {
               featureForm.forceActiveFocus()
+              __activeProject.autosyncController?.setIsSyncPaused(true)
             }
           }
         },
@@ -198,7 +200,10 @@ Item {
       layerIsReadOnly: root.layerIsReadOnly
       layerIsSpatial: root.layerIsSpatial
 
-      onSaved: drawer.close()
+      onSaved: {
+        root.saveRequested()
+        drawer.close()
+      }
       onCanceled: drawer.close()
 
       onEditGeometryRequested: function( pair ) {

app/qml/form/MMFormPage.qml

@@ -471,7 +471,6 @@ Page {
 
     // rollback all changes if the layer is still editable
     root.controller.rollback()
-
     root.canceled()
   }
 

app/qml/form/MMFormStackController.qml

@@ -255,6 +255,8 @@ Item {
   StackView {
     id: formsStack
 
+    property bool syncWhenFormCloses: false
+
     function popOneOrClose() {
       if ( formsStack.depth > 1 ) {
         formsStack.pop()
@@ -272,6 +274,18 @@ Item {
     focus: true
 
     anchors.fill: parent
+
+    // While the feature forms are open we block autosync triggers, so child features don't get synced before the parent
+    // is saved. After the last (parent) form is closed we enable autosync again and trigger it.
+    onDepthChanged: {
+      if (depth === 0) {
+        __activeProject.autosyncController?.setIsSyncPaused(false)
+        if (syncWhenFormCloses) {
+          __activeProject.autosyncController?.syncLayerChange()
+          syncWhenFormCloses = false
+        }
+      }
+    }
   }
 
   Component {
@@ -288,6 +302,10 @@ Item {
         }
       }
 
+      onSaveRequested: {
+        formsStack.syncWhenFormCloses = true
+      }
+
       onPreviewPanelChanged: function( panelHeight ) {
         root.previewPanelChanged( panelHeight )
       }

app/test/testmerginapi.cpp

@@ -2368,22 +2368,22 @@ void TestMerginApi::testAutosync()
   // 5. make sure autosync controller triggers that data has changed
   //
 
-  QString projectname = QStringLiteral( "testAutosync" );
-  QString projectdir = QDir::tempPath() + "/" + projectname;
-  QString projectfilename = "quickapp_project.qgs";
+  QString projectName = QStringLiteral( "testAutosync" );
+  QString projectDir = QDir::tempPath() + "/" + projectName;
+  QString projectFilename = QStringLiteral( "quickapp_project.qgs" );
 
-  InputUtils::cpDir( TestUtils::testDataDir() + "/planes", projectdir );
+  InputUtils::cpDir( TestUtils::testDataDir() + QStringLiteral( "/planes" ), projectDir );
 
   MapThemesModel mtm;
   AppSettings as;
   ActiveLayer al;
   ActiveProject activeProject( as, al, mApi->localProjectsManager() );
 
-  mApi->localProjectsManager().addLocalProject( projectdir, projectname );
+  mApi->localProjectsManager().addLocalProject( projectDir, projectName );
 
   as.setAutosyncAllowed( true );
 
-  QVERIFY( activeProject.load( projectdir + "/" + projectfilename ) );
+  QVERIFY( activeProject.load( projectDir + QStringLiteral( "/" ) + projectFilename ) );
   QVERIFY( activeProject.localProject().isValid() );
 
   QSignalSpy syncSpy( &activeProject, &ActiveProject::syncActiveProject );