Remove remaining memref.dealloc after InsertGpuAllocs pass#3
Open
dchigarev wants to merge 11 commits intoMenooker:devfrom
Open
Remove remaining memref.dealloc after InsertGpuAllocs pass#3dchigarev wants to merge 11 commits intoMenooker:devfrom
memref.dealloc after InsertGpuAllocs pass#3dchigarev wants to merge 11 commits intoMenooker:devfrom
Conversation
Signed-off-by: dchigarev <dmitry.chigarev@intel.com>
Signed-off-by: dchigarev <dmitry.chigarev@intel.com>
Signed-off-by: dchigarev <dmitry.chigarev@intel.com>
This PR aligns IMEX with the new LLVM version in GC (introduced here: intel/graph-compiler#204) The update has broken the following tests in IMEX (namely this assert statement now fails), I'm not sure what exactly caused this problem (my changes to IMEX or new LLVM versions). We don't use XeTile in our linalg->xegpu->gpu exe pipeline, so our flow is not affected by this problem.
Signed-off-by: dchigarev <dmitry.chigarev@intel.com>
memref.dealloc in InsertGpuAllocs passmemref.dealloc after InsertGpuAllocs pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the following buggy behavior that caused double deallocations:
This bug causes xegpu pipeline in graph compiler to crash on big tensors. I've noticed this problem for the first time on the new tests added by intel/graph-compiler#220. @LongshengDu have you encountered this problem already? Maybe you have another fix?
crash dump that I've seen in GC