Align with new LLVM version used in GC#2
Merged
Menooker merged 2 commits intoMenooker:devfrom Aug 2, 2024
Merged
Conversation
Signed-off-by: dchigarev <dmitry.chigarev@intel.com>
Signed-off-by: dchigarev <dmitry.chigarev@intel.com>
dchigarev
commented
Aug 1, 2024
| @@ -1,28 +0,0 @@ | |||
| From 283951f026428a3c34b8a2b8f2498d55faf590f5 Mon Sep 17 00:00:00 2001 | |||
Author
There was a problem hiding this comment.
this patch is no longer appliable (seems that this has been fixed in upstream)
Menooker
approved these changes
Aug 2, 2024
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aligns IMEX with the new LLVM version in GC (introduced here: intel/graph-compiler#204)
The update has broken the following tests in IMEX (namely this assert statement now fails), I'm not sure what exactly caused this problem (my changes to IMEX or new LLVM versions). We don't use
XeTilein ourlinalg->xegpu->gpu exepipeline, so our flow is not affected by this problem.