fix(bridge): derive profileId dynamically from MEMOS_HOME#1949
Open
redashes1984 wants to merge 1 commit into
Open
fix(bridge): derive profileId dynamically from MEMOS_HOME#1949redashes1984 wants to merge 1 commit into
redashes1984 wants to merge 1 commit into
Conversation
Fix: bridge.cts hardcoded profileId: "default", causing all profile-specific data to be invisible in the memOS web viewer for non-default profiles. The Python adapter already derives profileId correctly from HERMES_HOME. This change mirrors that logic in the Node.js bridge. - Add deriveProfileId() function that parses profile name from MEMOS_HOME path - Parse /profiles/<name>/ pattern to extract profile identifier - Fallback to "default" if MEMOS_HOME is not set or path does not match - Impact: zero for single-profile/default setups (still resolves to "default") Fixes profile resolution issue reported by nova profile users.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: Bug Fix
about: Create a report to help us improve
Issue: dist/bridge.cjs missing dynamic profileId resolution from bridge.cts
Problem
The
bridge.ctssource file hardcodedprofileId: "default", causing all profile-specific data to be invisible in the memOS web viewer when using multi-profile Hermes setups.Root Cause
bridge.ctshardcodedprofileId: "default"inbootstrapMemoryCoreFull()callHERMES_HOMESymptoms
defaultprofilenova)Environment
novaunder multi-profile setup (~/.hermes/profiles/nova/)Expected Behavior
bridge.ctsshould deriveprofileIddynamically fromMEMOS_HOMEenvironment variable.Actual Behavior
bridge.ctshardcodesprofileId: "default", filtering out all profile-specific data.Fix
Added
deriveProfileId()function that:MEMOS_HOMEenvironment variable/profiles/<name>/"default"ifMEMOS_HOMEis not set or path doesn't matchImpact
"default")Testing
nova(~19K traces)owner_profile_idvalues correctly resolvedWorkaround (for users who cannot upgrade)
Manually patch
dist/bridge.cjsor update databaseowner_profile_idvalues to match the profile name.