Simple fix to save mount from being deleted by Drop Disconnect Lag Dupe fix#22
Open
cdstk wants to merge 1 commit intoMeldexun:masterfrom
Open
Simple fix to save mount from being deleted by Drop Disconnect Lag Dupe fix#22cdstk wants to merge 1 commit intoMeldexun:masterfrom
cdstk wants to merge 1 commit intoMeldexun:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix #18
Vanilla Server behavior is player can logout on a mount and relog mounted on the entity. This fix prevents the mounted entity from being deleted by dismounting the player before vanilla saves and processes mounts, however it does not remount the player on login.
Vanilla behavior of PlayerList.playerLoggedOut() goes in this order:
Behavior with Fix Drop Disconnect Lag Dupe enabled is generally this: