Add real WebSocket integration tests to dart_node_ws#39
Merged
MelbourneDeveloper merged 3 commits intoMelbourneDeveloper:mainfrom Jan 27, 2026
Merged
Conversation
Owner
|
Hey thanks @ajayi-joseph This one needs a
|
Contributor
Author
|
Yeah. I'll fix that now. This is a 1 of 3 PRs for websocket. |
Contributor
Author
|
@MelbourneDeveloper .. Should be ready for review/merge shortly |
Owner
|
Thankyou @ajayi-joseph |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This PR implements real integration tests for the dart_node_ws package, replacing the previous TODO. The new tests verify actual client-server WebSocket communication using Node.js ws for the client via JS interop. All tests pass, and the implementation follows project guidelines (typed APIs, no duplication, Result<T,E> usage, and no global state).
Checklist