Skip to content

Pod Log Retrieval API & Validation Failure Log Preservation #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
paras-agarwal-meesho wants to merge 8 commits into from
Closed

Pod Log Retrieval API & Validation Failure Log Preservation #350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
cc2e7b6
Add ArgoCD pod logs retrieval API
paras-agarwal-meesho Feb 25, 2026
f8afae4
Persist Validation failure logs
paras-agarwal-meesho Feb 27, 2026
d4e7a39
preserve validation logs: correct tests
paras-agarwal-meesho Feb 27, 2026
6987284
preserve validation log: fix bug
paras-agarwal-meesho Feb 27, 2026
f333147
Persist valildation logs: fix tests
paras-agarwal-meesho Mar 2, 2026
a7cf856
Merge branch 'develop' into feat/failed-validation-logs
paras-agarwal-meesho Mar 2, 2026
dc8bc53
Persist validation logs: fix bugs
paras-agarwal-meesho Mar 2, 2026
0f2fbe4
Persist validation logs: fix bugs
paras-agarwal-meesho Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
116 changes: 113 additions & 3 deletions horizon/internal/infrastructure/controller/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,15 @@
package controller

import (
"errors"
"fmt"
"net/http"
"strconv"
"strings"

infrastructurehandler "github.com/Meesho/BharatMLStack/horizon/internal/infrastructure/handler"
workflowHandler "github.com/Meesho/BharatMLStack/horizon/internal/workflow/handler"
"github.com/Meesho/BharatMLStack/horizon/pkg/argocd"
"github.com/gin-gonic/gin"
)

Expand All @@ -18,17 +22,22 @@ func getWorkingEnv(ctx *gin.Context) string {
ctx.JSON(http.StatusInternalServerError, gin.H{"error": "workingEnv not found in context"})
return ""
}
return workingEnv.(string)
workingEnvStr, ok := workingEnv.(string)
if !ok {
ctx.JSON(http.StatusInternalServerError, gin.H{"error": "workingEnv has invalid type"})
return ""
}
return workingEnvStr
}

type InfrastructureController struct {
handler infrastructurehandler.InfrastructureHandler
handler infrastructurehandler.InfrastructureHandler
workflowHandler workflowHandler.Handler
}

func NewController() *InfrastructureController {
return &InfrastructureController{
handler: infrastructurehandler.InitInfrastructureHandler(),
handler: infrastructurehandler.InitInfrastructureHandler(),
workflowHandler: workflowHandler.GetWorkflowHandler(),
}
}
Expand Down Expand Up @@ -61,6 +70,17 @@ type UpdateAutoscalingTriggersRequest struct {
Triggers []interface{} `json:"triggers" binding:"required"` // Array of trigger objects (CPU, cron, prometheus, etc.)
}

// ApplicationLogsQuery holds query params for GET /applications/:appName/logs
type ApplicationLogsQuery struct {
PodName string `form:"podName"`
Container string `form:"container"`
Follow bool `form:"follow"`
Previous bool `form:"previous"`
SinceSeconds string `form:"sinceSeconds"` // string int64, default "0"
TailLines string `form:"tailLines"` // string int64, default "1000"
Filter string `form:"filter"`
}

func (c *InfrastructureController) GetHPAConfig(ctx *gin.Context) {
appName := ctx.Param("appName")
workingEnv := getWorkingEnv(ctx)
Expand Down Expand Up @@ -103,6 +123,96 @@ func (c *InfrastructureController) GetResourceDetail(ctx *gin.Context) {
ctx.JSON(http.StatusOK, resourceDetail)
}

func (c *InfrastructureController) GetApplicationLogs(ctx *gin.Context) {
appName := strings.TrimSpace(ctx.Param("appName"))
workingEnv := getWorkingEnv(ctx)
if workingEnv == "" {
return
}
if appName == "" {
ctx.JSON(http.StatusBadRequest, gin.H{"error": gin.H{
"message": "appName is required",
}})
return
}

var q ApplicationLogsQuery
if err := ctx.ShouldBindQuery(&q); err != nil {
ctx.JSON(http.StatusBadRequest, gin.H{"error": gin.H{
"message": "invalid query parameters",
}})
return
}

container := strings.TrimSpace(q.Container)
if container == "" {
ctx.JSON(http.StatusBadRequest, gin.H{
"error": gin.H{
"message": "container is required",
},
})
return
}

if q.Follow {
ctx.JSON(http.StatusBadRequest, gin.H{
"error": gin.H{
"message": "streaming (follow=true) is not supported",
},
})
return
}

sinceSeconds := int64(0)
if q.SinceSeconds != "" {
var err error
sinceSeconds, err = strconv.ParseInt(q.SinceSeconds, 10, 64)
if err != nil || sinceSeconds < 0 {
ctx.JSON(http.StatusBadRequest, gin.H{"error": gin.H{
"message": "sinceSeconds must be a non-negative integer",
}})
return
}
}
tailLines := int64(1000)
if q.TailLines != "" {
var err error
tailLines, err = strconv.ParseInt(q.TailLines, 10, 64)
if err != nil || tailLines < 0 {
ctx.JSON(http.StatusBadRequest, gin.H{"error": gin.H{
"message": "tailLines must be a non-negative integer",
}})
return
}
}
Comment on lines +177 to +187
Copy link

@coderabbitai coderabbitai bot Feb 27, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

tailLines=0 is accepted here but not honored downstream.

Line 181 accepts 0, but the URL builder later coerces non-positive values to 1000, so caller intent is lost. Please make this contract consistent (either reject 0 here or preserve 0 end-to-end).

One consistent option (reject 0 at API layer) 
 	if q.TailLines != "" {
 		var err error
 		tailLines, err = strconv.ParseInt(q.TailLines, 10, 64)
-		if err != nil || tailLines < 0 {
+		if err != nil || tailLines <= 0 {
 			ctx.JSON(http.StatusBadRequest, gin.H{"error": gin.H{
-				"message": "tailLines must be a non-negative integer",
+				"message": "tailLines must be a positive integer",
 			}})
 			return
 		}
 	}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
tailLines := int64(1000)
if q.TailLines != "" {
var err error
tailLines, err = strconv.ParseInt(q.TailLines, 10, 64)
if err != nil || tailLines < 0 {
ctx.JSON(http.StatusBadRequest, gin.H{"error": gin.H{
"message": "tailLines must be a non-negative integer",
}})
return
}
}
tailLines := int64(1000)
if q.TailLines != "" {
var err error
tailLines, err = strconv.ParseInt(q.TailLines, 10, 64)
if err != nil || tailLines <= 0 {
ctx.JSON(http.StatusBadRequest, gin.H{"error": gin.H{
"message": "tailLines must be a positive integer",
}})
return
}
}
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@horizon/internal/infrastructure/controller/controller.go` around lines 177 -
187, The handler currently allows tailLines == 0 but downstream URL builder
coerces non-positive values to 1000; make the contract consistent by rejecting 0
at the API layer: in the block that parses q.TailLines (the tailLines variable
and strconv.ParseInt usage around q.TailLines), change the validation to require
tailLines > 0 and return a 400 with a message like "tailLines must be a positive
integer" when it's 0 or negative; this preserves caller intent and aligns with
the URL builder behavior.

Copy link
Author

@paras-agarwal-meesho paras-agarwal-meesho Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intended

Copy link

@coderabbitai coderabbitai bot Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paras-agarwal-meesho, understood! I've noted that this is the intended behavior for the API.

✏️ Learnings added 
Learnt from: paras-agarwal-meesho
Repo: Meesho/BharatMLStack PR: 350
File: horizon/internal/infrastructure/controller/controller.go:177-187
Timestamp: 2026-03-02T08:28:59.803Z
Learning: In the BharatMLStack horizon GetApplicationLogs API endpoint (horizon/internal/infrastructure/controller/controller.go), accepting tailLines=0 at the API validation layer while coercing it to 1000 downstream in the URL builder is intentional behavior, not a bug.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.

🧠 Learnings used 
Learnt from: pavan-adari-meesho
Repo: Meesho/BharatMLStack PR: 272
File: horizon/internal/jobs/bulkdeletestrategy/strategy_selector.go:91-110
Timestamp: 2026-02-04T10:11:03.858Z
Learning: Within the BharatMLStack horizon codebase, ensure that service names (inferflow, predator, numerix) are stored in lowercase in database tables and are consistently used in lowercase throughout the code. During reviews, audit SQL queries, ORM mappings, constants, and string comparisons for these service names to confirm they are lowercase; if any uppercase or mixed-case usages are found, convert to lowercase and add a regression check to prevent reintroduction of uppercase variants.


opts := &argocd.ApplicationLogsOptions{
PodName: q.PodName,
Container: container,
Previous: q.Previous,
SinceSeconds: sinceSeconds,
TailLines: tailLines,
Filter: q.Filter,
}

entries, err := c.handler.GetApplicationLogs(appName, workingEnv, opts)
if err != nil {
status := http.StatusInternalServerError
var apiErr *argocd.ArgoCDAPIError
if errors.As(err, &apiErr) {
status = apiErr.StatusCode
}
ctx.JSON(status, gin.H{
"error": gin.H{
"message": err.Error(),
},
})
return
}

ctx.JSON(http.StatusOK, entries)
}

func (c *InfrastructureController) RestartDeployment(ctx *gin.Context) {
appName := ctx.Param("appName")
workingEnv := getWorkingEnv(ctx)
Expand Down
Loading