Improve HealthBench parity with openai/simple-evals#132
Open
bofenghuang wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tightens HealthBench's parity with openai/simple-evals and adds the Professional variant.
Changes
try/except AttributeErroraround_parse_jsonnever fired (the parser returns{}on bad JSON), so malformed grading responses were silently scoredcriteria_met=Falseand the existingrerun_judgepath was dead code. Retry is now driven by the real failure signals (judge error, empty raw, or missing/non-booleancriteria_met), bounded by a newmax_judge_retriesarg (default3).length_adjusted_score) matching simple-evals' formula. Computed in orderraw → length adjust → clip to [0, 1]. Length-adjustment is opt-in but auto-applied when both knobs areNone, using OpenAI's published per-variant defaults (regular0.0299, hard0.0392, consensus0.0020, professional0.0147;center=2000for all).use_length_adjusted_as_rewardflag (defaultFalse) that swaps weights solength_adjusted_scorebecomes the headline reward; useful for RL training. Both numbers are always reported either way.difficulty="professional", 525 rows). Different upstream schema (conversation/rubric_items/id, no per-rubric tags) is projected onto the canonical shape at load time via_normalize_to_canonical_schema. Rubric-level axis/consensus slicing is unavailable for this variant; example-level tags (use_case,type,difficulty,specialty) are surfaced ininfofor analytics.HEALTHBENCH_DATASET_MAPPINGdict.K > 1).Test plan
uv run ruff check environments/healthbench/ && uv run ruff format --check environments/healthbench/— clean.all,hard,consensus,professional) loads, normalization for professional produces correct canonical fields (prompt,prompt_id,rubrics,example_tags) plus expectedinfo(theme=professional,axes=[None, ...]).length_adjustment_*both-or-neither, non-negative, anduse_length_adjusted_as_reward=Truerequiring length-adjustment all raiseValueErroras expected.