Skip to content

Implement #633: VTL regular names must be case insensitive#634

Draft
mla2001 wants to merge 7 commits into
mainfrom
cr-633
Draft

Implement #633: VTL regular names must be case insensitive#634
mla2001 wants to merge 7 commits into
mainfrom
cr-633

Conversation

@mla2001
Copy link
Copy Markdown
Contributor

@mla2001 mla2001 commented Mar 26, 2026

Summary

Regular names are now case insensitive.

Checklist

  • Code quality checks pass (ruff format, ruff check, mypy)
  • Tests pass (pytest)
  • Documentation updated (if applicable)

@mla2001 mla2001 self-assigned this Mar 26, 2026
@mla2001 mla2001 requested review from a team and javihern98 March 26, 2026 17:17
@mla2001 mla2001 linked an issue Mar 26, 2026 that may be closed by this pull request
2 tasks
@mla2001 mla2001 changed the title Cr 633 Implement #Cr 633: Mar 26, 2026
@mla2001 mla2001 changed the title Implement #Cr 633: Implement #Cr 633: VTL regular names must be case insensitive Mar 26, 2026
@javihern98 javihern98 changed the title Implement #Cr 633: VTL regular names must be case insensitive Implement #633: VTL regular names must be case insensitive Mar 27, 2026
Copy link
Copy Markdown
Contributor

@javihern98 javihern98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! 😊

Copy link
Copy Markdown
Contributor

@javihern98 javihern98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to handle as well these kind of cases, output component for calc and aggr:

    script = """
        DS_A <- DS_1[calc me_1 := mE_1 * 10];
    """

    data_structures = {
        "datasets": [
            {
                "name": "DS_1",
                "DataStructure": [
                    {"name": "Id_1", "type": "Integer", "role": "Identifier", "nullable": False},
                    {"name": "Me_1", "type": "Number", "role": "Measure", "nullable": True},
                ],
            }
        ]
    }

    data_df = pd.DataFrame({"Id_1": [1, 2, 3], "Me_1": [10, 20, 30]})

    datapoints = {"DS_1": data_df}

    run_result = run(script=script, data_structures=data_structures, datapoints=datapoints)

    print(run_result)

@mla2001 mla2001 requested a review from javihern98 April 10, 2026 09:46
@mla2001 mla2001 marked this pull request as draft April 10, 2026 09:47
@mla2001 mla2001 marked this pull request as draft April 10, 2026 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VTL regular names must be case insensitive

2 participants