fix(3-6): accept Integer default for non-Boolean cells#81
Closed
ruizmaa wants to merge 63 commits into
Closed
Conversation
The refactor to call_args-based assertions dropped the "called exactly once" check. Restores it at both call sites without requiring the assertion to know about the new output_path keyword arg. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…es in visitLiteral
A2 - Extend `sub` to accept multiple substitutions
A12 - Relax `time_shift` `numberPeriods` to accept integer expressions
A1 - Relax `not` to prefix unary operator (no mandatory parentheses)
…d-type Fix/3 6 null default mixed type
…directional fix(3-6): accept String default for cells whose type promotes to String
Fix semantic UNKNOWN error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(3-6): accept Integer default for non-Boolean cells
__check_default_valueraised 3-6 forInteger 0defaults onItemandTimeIntervalcells because no direct promotion path exists between those types.The fix adds a third acceptance condition: if both types share a common promotion
target (their promotion sets intersect) and neither is
Boolean, the default isvalid. In practice this means
0is accepted as a numeric null sentinel for anynon-Boolean cell type.
Impact
7 operations no longer raise 3-6.
with {tB_01.02, default: 0, interval: false}: if (not (isnull ({c0110}))) ...with {tB_01.02, default: 0, interval: false}: if ({c0040} != [eba_CT:x318] ...with {tB_02.01, default: 0, interval: false}: if ({c0020} = [eba_CO:x3]) ...with {tB_02.02, default: 0, interval: false}: {c0080} > {c0070}with {tB_05.01, default: 0, interval: false}: if ({c0070} = [eba_CT:x212]) ...with {tB_05.01, default: 0, interval: false}: if ({c0020} = [eba_qCO:qx2000]) ...with {tB_07.01, default: 0, interval: false}: if {c0050} = [eba_ZZ:x959] ...Checklist
ruff format,ruff check,mypy)pytest) with 100% branch coverage (coverage report --fail-under=100)Impact / Risk
Notes