pkg_resources replaced with importlib.resources + change to github workflow main.yaml file #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnearing
had a problem deploying
to
publish-release
GitHub Actions
Failure
dnearing
had a problem deploying
to
publish-release
GitHub Actions
Failure
dnearing
had a problem deploying
to
publish-release
GitHub Actions
Failure
…lish-package job.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #22 +/- ##
==========================================
- Coverage 33.87% 33.81% -0.06%
==========================================
Files 12 12
Lines 1656 1653 -3
==========================================
- Hits 561 559 -2
+ Misses 1095 1094 -1 ☔ View full report in Codecov by Sentry. |
dnearing
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces pkg_resources with importlib.resources in some mkidcore files. Closes issue #9. Also made a simple edit to .github/workflows/main.yaml. That change closes issue #23.