This repository was archived by the owner on Nov 21, 2024. It is now read-only.
Multiple fixes#26
Open
bydos wants to merge 2 commits intoMazeMap:masterfrom
Open
Conversation
Fixes: 1- Compatibility with PouchDB 6.x 2- Extending TileLayer to avoid conflicts with other plugins that also modify internal methods of TileLayer 3- Fix the seed() function 3.a- Fix the tiles coordinates generation 3.b- Fix asynchronous calls of recursive SeedOneTile() method 4- Add dbSizeLimit option to avoid excessive seeding (needs more considerations)
Update L.TileLayer.PouchDBCached.js
Contributor
|
@bydos Looks good, but there are a number of things I'm not happy about. The comments might seem a bit harsh (I don't have the time to write them nicer, sorry!), please have a look at them. |
Author
|
@IvanSanchez , Yes it was done a bit quickly. It was just to give some orientations, not really a clean PR. I am a little bit busy this couple of days sorry, but when I get enough time I will consider a global review and also some enhancements. Thanks |
|
Any updates on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1- Fix PouchDB 6.x compatibility
2- Fix Tile coordinates generation for TMS layers (y coordinates)
3- Asynchronous call for the recursive SeedOneTile() method
4- Add dbSizeLimit option to avoid excessive seeding (needs more considerations)
5- Extending L.TileLayer to L.TileLayer.PouchDB to avoid conflicts with other plugins that modify internal methods