Open
Conversation
|
Glad to see this being addressed. This fix covers the RCE/Path Traversal issues I reported earlier in Issue #235 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a configurable allow-list for downloadable websites, improving security by restricting which hosts are permitted for inventory downloads. It also refactors the download logic to provide clearer error handling and user feedback, and enhances file name validation to prevent unsafe or malformed file names.
Security and Configuration Enhancements:
allowedDownloadableWebsiteinConfiguration.javaand the config file, defaulting tominecraft-inventory-builder.com, to specify which hosts are allowed for inventory downloads. The config is now loaded and saved accordingly. [1] [2] [3] [4]ZWebsiteManagernow checks if the requested host matches an entry inallowedDownloadableWebsite, rejecting downloads from unauthorized hosts.User Feedback and Error Handling Improvements:
DownloadResultenum to clearly distinguish different download outcomes, enabling user-friendly error messages for cases such as unauthorized hosts, invalid file types, and file existence. [1] [2]WEBSITE_DOWNLOAD_ERROR_HOSTto inform users when a download is rejected due to an unapproved host, displaying both the attempted host and the allowed hosts.File Name Validation:
Content-Dispositionheader, ensuring only safe, well-formed names are used and falling back to a random name if necessary.…oad error handling