Skip to content

Do not use root logger for URL requests #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fsvenson wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Do not use root logger for URL requests #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions maxarcat/catalog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ def get_url(self, url: str) -> bytes:
:param url: Any catalog URL that supports GET.
:return: Response body as bytes
"""
logging.info(f'GET {url}')
Catalog.logger.info(f'GET {url}')
return self._request_url(requests.get, url)

def get_url_json(self, url: str):
Expand All @@ -319,7 +319,7 @@ def get_url_json(self, url: str):
:param url: URL from an item's asset's href property
:return: Parsed JSON, generally returning a dict
"""
logging.info(f'GET {url}')
Catalog.logger.info(f'GET {url}')
response = self._request_url(requests.get, url)
try:
return json.loads(str(response, encoding='utf-8'))
Expand Down