Skip to content

Conversation

@joshterrill
Copy link

I removed node_modules/ from the commit as it was already in the .gitignore file. I also took out all of the old express modules like body-parser, cookie-parser, and logger and replaced them with their own independent modules since they are no longer supported as native modules. I also reinstalled the dependencies and added the proper fields to the package.json so that when you ran an npm install it would actually work. Start the app up using npm start now.

@MaxGfeller
Copy link
Owner

Yay, thanks for contributing to my first (i think) and oldest github project! 🎉

Would really love to see this getting this back on track and actually make it usable. Do you want to use this? How did you find it?

Few things about your pull request: the following modules are not yet in the package.json but are used in the app:

  • morgan
  • body-parser
  • cookie-parser

Also, when trying to run it there appears a different error:

undefined:4
    + (tokens["id"](req, res, undefined) || "-") + " "
                   ^

TypeError: tokens.id is not a function
    at eval (eval at compile (/private/tmp/mongee/node_modules/morgan/index.js:383:10), <anonymous>:4:20)
    at Array.logRequest (/private/tmp/mongee/node_modules/morgan/index.js:122:18)
    at listener (/private/tmp/mongee/node_modules/morgan/node_modules/on-finished/index.js:169:15)
    at onFinish (/private/tmp/mongee/node_modules/morgan/node_modules/on-finished/index.js:100:5)
    at callback (/private/tmp/mongee/node_modules/morgan/node_modules/on-finished/node_modules/ee-first/index.js:55:10)
    at ServerResponse.onevent (/private/tmp/mongee/node_modules/morgan/node_modules/on-finished/node_modules/ee-first/index.js:93:5)
    at emitNone (events.js:72:20)
    at ServerResponse.emit (events.js:166:7)
    at finish (_http_outgoing.js:526:10)
    at doNTCallback0 (node.js:407:9)
    at process._tickCallback (node.js:336:13)

Any idea on where this may come from?

@joshterrill
Copy link
Author

I thought added --save when I added those dependencies. I'll take a look at
it when I'm in front of my computer again and we can talk more. (PST time
zone, I'll be back at it in ~8.5 hours)
On Oct 12, 2015 12:50 AM, "Max Gfeller" notifications@github.com wrote:

Yay, thanks for contributing to my first (i think) and oldest github
project! [image: 🎉]

Would really love to see this getting this back on track and actually make
it usable. Do you want to use this? How did you find it?

Few things about your pull request: the following modules are not yet in
the package.json but are used in the app:

  • morgan
  • body-parser
  • cookie-parser

Also, when trying to run it there appears a different error:

undefined:4
+ (tokens["id"](req, res, undefined) || "-") + " "
^

TypeError: tokens.id is not a function
at eval (eval at compile (/private/tmp/mongee/node_modules/morgan/index.js:383:10), :4:20)
at Array.logRequest (/private/tmp/mongee/node_modules/morgan/index.js:122:18)
at listener (/private/tmp/mongee/node_modules/morgan/node_modules/on-finished/index.js:169:15)
at onFinish (/private/tmp/mongee/node_modules/morgan/node_modules/on-finished/index.js:100:5)
at callback (/private/tmp/mongee/node_modules/morgan/node_modules/on-finished/node_modules/ee-first/index.js:55:10)
at ServerResponse.onevent (/private/tmp/mongee/node_modules/morgan/node_modules/on-finished/node_modules/ee-first/index.js:93:5)
at emitNone (events.js:72:20)
at ServerResponse.emit (events.js:166:7)
at finish (_http_outgoing.js:526:10)
at doNTCallback0 (node.js:407:9)
at process._tickCallback (node.js:336:13)

Any idea on where this may come from?


Reply to this email directly or view it on GitHub
#2 (comment).

@MaxGfeller
Copy link
Owner

Alright, no worries. Also, i think parse-body doesn't really work the exact same way; it throws an error while creating a user. That might need some refactoring, too.

@joshterrill
Copy link
Author

I just added a commit to fix the missing packages. I haven't been able to get it working yet because of some issues with my mongod service. Do you think you can post some screenshots of what the app looks like? My co-workers and I are looking at trying to find a simple social media platform that is written in NodeJS / Mongo.

@MaxGfeller
Copy link
Owner

Ok, i'll merge these as soon as i get some time and try to fix the remaining errors. I can post some screenshots if you want, but it really isn't anywhere near to be usable and needs lots of love first.

@joshterrill
Copy link
Author

That's fine. Maybe we can chat over Skype so you can explain to me exactly
what your goal for this project is. My Skype name is joshuaterrill if you'd
like to add me.
On Oct 13, 2015 2:13 AM, "Max Gfeller" notifications@github.com wrote:

Ok, i'll merge these as soon as i get some time and try to fix the
remaining errors. I can post some screenshots if you want, but it really
isn't anywhere near to be usable and needs lots of love first.


Reply to this email directly or view it on GitHub
#2 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants