-
Notifications
You must be signed in to change notification settings - Fork 8
Updated and cleaned the app #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Yay, thanks for contributing to my first (i think) and oldest github project! 🎉 Would really love to see this getting this back on track and actually make it usable. Do you want to use this? How did you find it? Few things about your pull request: the following modules are not yet in the
Also, when trying to run it there appears a different error: Any idea on where this may come from? |
|
I thought added --save when I added those dependencies. I'll take a look at
|
|
Alright, no worries. Also, i think |
|
I just added a commit to fix the missing packages. I haven't been able to get it working yet because of some issues with my |
|
Ok, i'll merge these as soon as i get some time and try to fix the remaining errors. I can post some screenshots if you want, but it really isn't anywhere near to be usable and needs lots of love first. |
|
That's fine. Maybe we can chat over Skype so you can explain to me exactly
|
I removed
node_modules/from the commit as it was already in the.gitignorefile. I also took out all of the old express modules like body-parser, cookie-parser, and logger and replaced them with their own independent modules since they are no longer supported as native modules. I also reinstalled the dependencies and added the proper fields to thepackage.jsonso that when you ran annpm installit would actually work. Start the app up usingnpm startnow.