feat: update ci#53
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThis PR modernizes the PyMax project by adopting ChangesProject Modernization
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (2 warnings, 1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/publish.yml:
- Around line 21-25: Replace tag-based GitHub Action references with immutable
commit SHAs: locate the uses lines referencing actions/checkout@v6,
astral-sh/setup-uv@v8.1.0, actions/upload-artifact@v4, and
actions/download-artifact@v4 in the publish workflow and pin each to the
corresponding repository commit SHA (e.g., actions/checkout@<full-sha>) instead
of the tag; update every occurrence of those symbols so the workflow uses full
SHAs for reproducible runs and commit the changed publish.yml.
In @.github/workflows/tests.yml:
- Around line 22-26: Replace the floating GitHub Action tags with immutable
commit SHAs for every occurrence of the actions referenced (specifically the
uses entries "actions/checkout@v6" and "astral-sh/setup-uv@v8.1.0" found in both
the lint and tests job blocks); locate those uses entries and update them to the
corresponding repository@<commit-SHA> values (fetch the latest recommended
commit SHAs from each action's repo/releases page), commit the updated workflow,
and run CI to verify the workflows still function after pinning.
In `@src/pymax/api/models.py`:
- Around line 6-10: Ruff flags formatting in the multi-line ConfigDict call for
model_config; reformat the ConfigDict(...) block so arguments are each on their
own line, the closing parenthesis is on its own line, no trailing whitespace or
extra blank lines remain, and overall alignment matches surrounding code style
(edit the model_config assignment and ConfigDict invocation that uses to_camel,
populate_by_name, and arbitrary_types_allowed).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5486026b-0bbe-40b9-acb2-513cb7d60c72
📒 Files selected for processing (4)
.github/workflows/publish.yml.github/workflows/tests.ymlpyproject.tomlsrc/pymax/api/models.py
Summary by CodeRabbit
New Features
Documentation
Chores