Draft
Conversation
ztozh
force-pushed
the
update25.11.06
branch
4 times, most recently
from
9aa6380 to
f889dc9
Compare
…plit compilation mode; Disable incremental linking; Fix [AdditionalOptions] definitions for debug configurations for ll-files; Fix false-positive build error on built-in Error event; Rename [Debug] configuration to [debug]; Rename [Release] configuration to [release]; Replace output file for files without regular compilation; Replace the path separator [\] with [/] when calling MSBuild; Switch to upcoming SL; Use UTF-8 for compiler output when calling MSBuild
ztozh
force-pushed
the
update25.11.06
branch
from
6a4f987 to
51eaf54
Compare
Parean
suggested changes
Dec 9, 2025
|
|
||
| protected override bool HandleTaskExecutionErrors() | ||
| { | ||
| base.HandleTaskExecutionErrors(); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| <AdditionalOptions Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">-O0 -Wno-override-module -c -target x86_64-pc-windows $(AdditionalOptions)</AdditionalOptions> | ||
| <AdditionalOptions Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">-O3 -Wno-override-module -c -target i386-pc-windows $(AdditionalOptions)</AdditionalOptions> | ||
| <AdditionalOptions Condition="'$(Configuration)|$(Platform)'=='Release|x64'">-O3 -Wno-override-module -c -target x86_64-pc-windows $(AdditionalOptions)</AdditionalOptions> | ||
| <AdditionalOptions Condition="'$(Configuration)|$(Platform)'=='assert|win32'">-O3 -Wno-override-module -c -target i386-pc-windows</AdditionalOptions> |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
|
||
| protected override bool HandleTaskExecutionErrors() | ||
| { | ||
| base.HandleTaskExecutionErrors(); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| <IntDir>x32_$(Configuration)\</IntDir> | ||
| <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='debug|win32'"> | ||
| <IntDir>$(Configuration)32\</IntDir> | ||
| <LinkIncremental>false</LinkIncremental> |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| <SDLCheck>true</SDLCheck> | ||
| <PreprocessorDefinitions>WIN32;_DEBUG;_CONSOLE;%(PreprocessorDefinitions)</PreprocessorDefinitions> | ||
| <ConformanceMode>true</ConformanceMode> | ||
| <PreprocessorDefinitions>%(PreprocessorDefinitions)</PreprocessorDefinitions> |
Contributor
There was a problem hiding this comment.
Shouldn't we directly specify Optimization with Disabled/MaxSpeed to ensure our configuration approach is followed?
|
|
||
| <!-- Replace output file for files without partial compilation --> | ||
| <MPL Condition="%(MPL.PartialCompilation) != true" OutputFile="$(IntDir)mpl.ll"/> | ||
| <MPL Condition="%(MPL.CompilationMode) != Regular" OutputFile="$(IntDir)$([System.String]::Copy(%(Identity)).Replace("\", "_")).ll"/> <!-- Replace output file for files without regular compilation --> |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| if (firstFile.GetMetadata("PartialCompilation") != "true") ActiveToolSwitches.Remove("PartialCompilation"); | ||
| else ActiveToolSwitches["PartialCompilation"] = new ToolSwitch(ToolSwitchType.String) { MultipleValues = true, SwitchValue = "-part" }; | ||
| string compilationMode = firstFile.GetMetadata("CompilationMode"); | ||
| if (compilationMode == "Partial") { ActiveToolSwitches["OutputFile"] = new ToolSwitch(ToolSwitchType.File) { SwitchValue = "-o ", Value = firstFile.GetMetadata("OutputFile") }; ActiveToolSwitches["PartialCompilation"] = new ToolSwitch(ToolSwitchType.String) { MultipleValues = true, SwitchValue = "-part" }; } |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Parean
approved these changes
Dec 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add [AbsolutePaths] MSBuild option
Add [assert] configuration
Add split compilation mode
Disable incremental linking
Switch to upcoming SL
Fix false-positive build error on built-in Error event
Fix [AdditionalOptions] definitions for debug configurations for ll-files
Use UTF-8 for compiler output when calling MSBuild
Rename [Debug] to [debug]
Rename [Release] to [release]
Replace output file for files without regular compilation
Replace path separator [\] with [/] when calling MSBuild