fix: camelcaseKeys does not support CommonJS #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move the pkgroll to only generate ESM files, not CommonJS this fixes the error "TypeError: camelcaseKeys is not a function" fix: circular references
Author
|
For reference: https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c The author has a pretty hard stance on not supporting CJS and expects you to move to ESM, away from CJS. Not a completely unreasonable expectation given ESM has been the standard for quite a while now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move pkgroll to only generate ESM files, not CommonJS.
This fixes the error "TypeError: camelcaseKeys is not a function" that appears to projects that user "esModuleInterop" and would default to attempting to use CJS files.
Why? camelcaseKeys is not compatible with CommonJS, only ESM.
Impact: probably no one because this project would not function (runtime error) for anyone using it as a CJS import.
Also fix: circular references (imports) to the routes.