Created a String Utils class #20
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthewBlanski
approved these changes
Dec 19, 2020
Owner
MatthewBlanski
left a comment
MatthewBlanski
left a comment
There was a problem hiding this comment.
Thank you for your hard work on this. I've added a few small comments but as this repo doesn't have a style guide they are more observations on the uses within the current code than anything specific.
Comment on lines
+4
to
+6
| * @summary | ||
| * Returns an empty string if its a null-ish value, otherwise returns | ||
| * the original string. |
Owner
There was a problem hiding this comment.
The description is a good thing to have. This does not follow the same-line example indicated in JS Doc for @summary
| @@ -1,6 +1,9 @@ | |||
| const StringUtils = require('../utils/stringUtils'); | |||
Owner
There was a problem hiding this comment.
Within this repo we're using the file extension in the require path. It's a mild stylistic issue and we don't have a style guide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2
Currently in a draft state to add more methods if needed.