Open
Conversation
MatthewARoy
commented
Oct 25, 2019
| let colonies = getAllColonies().filter(colony => colony.level > 6); | ||
| for (let colony of colonies) { | ||
| let route = Game.map.findRoute(colony.room, room); | ||
| if (room.name != 'W24N31' && route != -2 && route.length <= 8) { |
MatthewARoy
commented
Oct 30, 2019
Comment on lines
+497
to
+508
| // Order more power if needed | ||
| if (Game.market.credits > TraderJoe.settings.market.energyCredits) { | ||
| const averageEnergy = _.sum(this.terminals, terminal => colonyOf(terminal).assets[RESOURCE_POWER] || 0) | ||
| / this.terminals.length; | ||
| if (averageEnergy < 10000) { | ||
| const poorestTerminal = minBy(this.terminals, terminal => colonyOf(terminal).assets[RESOURCE_POWER] || 0); | ||
| if (poorestTerminal) { | ||
| const amount = 10000; | ||
| Overmind.tradeNetwork.maintainBuyOrder(poorestTerminal, RESOURCE_POWER, amount, 5); | ||
| } | ||
| } | ||
| } |
Comment on lines
+58
to
+60
| else if(RoomIntel.roomReservedBy(this.pos.roomName) == 'Invader') { | ||
| reserver.goTo(this.room.controller!.pos); | ||
| reserver.attackController(this.room.controller!); |
Owner
Author
There was a problem hiding this comment.
Make this a task please, same as reserve below
Comment on lines
-190
to
-196
| let fortifyTicks = 0; | ||
| let shouldFortify = this.colony.assets.energy > (Game.map.getRoomLinearDistance(this.room.name, 'W16N48') * 15000); | ||
| if (shouldFortify) { | ||
| fortifyTicks = 0.25 * _.sum(this.fortifyBarriers, barrier => | ||
| Math.max(0, WorkerOverlord.settings.barrierHits[this.colony.level] | ||
| - barrier.hits)) / REPAIR_POWER; | ||
| } |
Owner
Author
There was a problem hiding this comment.
Please leave this part here, I think this was you trying to rampart up even with no energy
Comment on lines
-208
to
+204
| if (this.colony.name == 'W14N57') { | ||
| //if (this.colony.name == 'W14N57') { | ||
| //numWorkers = 8; | ||
| } | ||
| //} |
Owner
Author
There was a problem hiding this comment.
Can just deleted all this
Comment on lines
+31
to
+42
| // OutpostDefenseOverlord can be used to harass low RCL rooms., stomp csites codes | ||
| if(this.room.name == zerg.room.name && zerg.hits == zerg.hitsMax){ | ||
| const enemyConstructionSites = zerg.room.find(FIND_HOSTILE_CONSTRUCTION_SITES, { | ||
| filter: function(csite: ConstructionSite) { | ||
| return csite.progress > 0; | ||
| } | ||
| }); | ||
| if (enemyConstructionSites.length > 0 && enemyConstructionSites[0].pos.isWalkable(true)) { | ||
| zerg.goTo(enemyConstructionSites[0].pos); | ||
| return; | ||
| } | ||
| } |
Owner
Author
There was a problem hiding this comment.
Lets not use the outpost defense for a harass op, should rework it. remove please
| private registerOutputRequests(): void { | ||
| if (this.container) { | ||
| if (_.sum(this.container.store) > 0.5 * this.container.storeCapacity || | ||
| if (_.sum(this.container.store) > 0.25 * this.container.storeCapacity || // changed from 0.5 to 0.25 |
Owner
Author
There was a problem hiding this comment.
Too general, if you're going to do that have it be only for SK rooms. I haven't had any issues with mineral pickup though
Comment on lines
+490
to
+508
| if(miner.getActiveBodyparts(HEAL) > 0){ | ||
| if(miner.hits < miner.hitsMax){ | ||
| miner.heal(miner); | ||
| } else { | ||
| const target = CombatTargeting.findClosestHurtFriendly(miner); | ||
| if (target) { | ||
| // Approach the target | ||
| const range = miner.pos.getRangeTo(target); | ||
| // Heal or ranged-heal the target | ||
| if (range <= 1) { | ||
| miner.heal(target); | ||
| } | ||
| else if (range <= 3) { | ||
| miner.rangedHeal(target); | ||
| } | ||
| } | ||
|
|
||
| } | ||
| } |
Owner
Author
There was a problem hiding this comment.
This is a very cpu expensive thing to do be doing. Constantly looking around you for hurt people and healing with one heal part? I don't want the miner heal tech I think.
| STRUCTURE_TERMINAL, | ||
| STRUCTURE_RAMPART, | ||
| STRUCTURE_WALL, | ||
| STRUCTURE_INVADER_CORE, |
Owner
Author
There was a problem hiding this comment.
Technically I don't think this is a buildable structure, should redefine constant tbh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request summary
Description:
Added:
Changed:
Removed:
Fixed:
Testing checklist:
tsconfigconfiguration