🛠️ Added weapon_type Field to Weapon Entities #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Added weapon_type Field to Weapon Entities
Context
Previously, weapon entities relied on the type field, which was language-dependent. This created limitations for translations, as the weapon type had to be specified for each language, reducing maintainability and increasing the chance of inconsistency.
What was done
✅ Added a new weapon_type field to all weapon entities
✅ The field follows the same structure and naming as the type field used in the character entities
✅ This change decouples weapon type from translations, ensuring it’s defined only once and shared across all locales
Why this matters
Prevents the need to define weapon type in every translation language
Aligns weapon structure with the character entity model
Enhances maintainability and consistency across all languages
Prepares the system for better internationalization (i18n) support