Add WSL Docker fallback for Sandcastle runtime#6
Conversation
MatheusBBarni
left a comment
MatheusBBarni
left a comment
There was a problem hiding this comment.
Reviewed the PR for the Docker runtime integration path. No blocking findings.
Checked the WSL fallback behavior in src-tauri/src/docker.rs, the shared usage from PRD/spec generation, chat, execution, and stop/remove paths, and the docs updates. The runtime now preserves host Docker behavior for macOS/Linux and converts Windows host paths only when using WSL Docker.
Local verification already run:
cargo check --manifest-path .\src-tauri\Cargo.tomlcargo test --manifest-path .\src-tauri\Cargo.tomlbun run build
No review comments to address at this time.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cb376ff634
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if let Some(api_key) = read_cursor_api_key()?.filter(|value| !value.trim().is_empty()) { | ||
| command.arg("-e").arg(format!("OPENAI_API_KEY={api_key}")); | ||
| return Ok(()); |
There was a problem hiding this comment.
providerAuthMode is now persisted in project settings, but this auth path ignores it and always prefers a stored API key when one exists. In projects configured for subscription, runs will still use OPENAI_API_KEY if present, so execution can silently use the wrong account/billing context and contradict the setting shown in the UI. Please thread the selected auth mode into runtime execution and branch here accordingly.
Useful? React with 👍 / 👎.
| if (environmentCodexStatus !== "found") { | ||
| return `Install or repair Codex CLI before generating a ${target}.`; | ||
| } |
There was a problem hiding this comment.
This validation now blocks PRD/spec generation unless host Codex CLI status is found, but the generation path runs codex exec inside the Docker image (run_cursor_agent_prompt_sync) and does not use a host Codex binary. As a result, users with working Docker + auth are incorrectly prevented from generating documents when Codex is not installed on the host.
Useful? React with 👍 / 👎.
1 participant
Summary
Verification