Refactor/cursor sdk#3
Conversation
…and-technical-spec Move PRD/Spec headers out of cards and reposition action buttons
- Guard resetRun with idle check to avoid unnecessary state transitions - Update useEffect dependencies for ChatRuntime sync - Set package to public in package.json
Commit workspace settings and skills configuration for AI agents (claude, kiro, pi, trae, etc.)
- Security: Enable CSP, add prompt boundary markers - Testing: Add vitest with 83 tests, Biome linter - Architecture: Extract App.tsx into focused hooks (1423→821 lines), split useAppView.ts into 4 files, split chat.rs into 5 submodules - Rust: Replace string enums with SessionStatus/AutonomyMode/MessageRole, deduplicate approval gate, batch disk writes, reduce cloning - Performance: React.lazy code splitting, React.memo on screens, optimize terminal buffer - Accessibility: aria-labels on all interactive controls - Config: private:true, explicit tailwindcss, meta description - Docs: Update SPEC.md and AGENTS.md
refactor: comprehensive project improvements - Security: Enable CSP, add prompt boundary markers - Testing: Add vitest with 83 tests, Biome linter - Architecture: Extract App.tsx into focused hooks (1423→821 lines), split useAppView.ts into 4 files, split chat.rs into 5 submodules - Rust: Replace string enums with SessionStatus/AutonomyMode/MessageRole, deduplicate approval gate, batch disk writes, reduce cloning - Performance: React.lazy code splitting, React.memo on screens, optimize terminal buffer - Accessibility: aria-labels on all interactive controls - Config: private:true, explicit tailwindcss, meta description - Docs: Update SPEC.md and AGENTS.md
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 37e96e597f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return AGENT_MODELS.some((model) => model.id === trimmedModelId) | ||
| ? trimmedModelId | ||
| : DEFAULT_MODEL_ID; |
There was a problem hiding this comment.
Do not coerce unknown model IDs to DEFAULT_MODEL_ID here, because this commit also made model options dynamic via cursorModels; any account-specific Cursor model not listed in AGENT_MODELS gets reset to composer-2 when project settings are loaded/saved through normalizeProjectSettings, so subsequent PRD/spec generation can run against the wrong model without the operator realizing it.
Useful? React with 👍 / 👎.
1 participant
No description provided.