Fix concurrent replica drop in frontend peek sequencing #34728
Merged
+35
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggevay
force-pushed
the
frontend-peek-concurrent-replica-drop
branch
from
5d55885 to
08b3820
Compare
ggevay
commented
Jan 16, 2026
| pub fn concurrent_dependency_drop_from_peek_error( | ||
| e: PeekError, | ||
| pub fn concurrent_dependency_drop_from_instance_peek_error( | ||
| e: mz_compute_client::controller::instance::PeekError, |
Contributor
Author
There was a problem hiding this comment.
(This one I just renamed and adjusted the imports, because now we have conversion functions for two different PeekError structs.)
ggevay
force-pushed
the
frontend-peek-concurrent-replica-drop
branch
from
08b3820 to
deba7d4
Compare
ggevay
requested review from
SangJunBak and
teskje
and removed request for
SangJunBak
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/MaterializeInc/database-issues/issues/10022