adding unit tests for custom swatch colors#4025
Open
MovGP0 wants to merge 1 commit intoMaterialDesignInXAML:masterfrom
Open
adding unit tests for custom swatch colors#4025MovGP0 wants to merge 1 commit intoMaterialDesignInXAML:masterfrom
MovGP0 wants to merge 1 commit intoMaterialDesignInXAML:masterfrom
Conversation
Keboo
reviewed
Mar 25, 2026
| public sealed class CustomSemanticSwatchTests | ||
| { | ||
| [Test] | ||
| public async Task CustomSemanticSwatches_ExtractExpectedThemeColors() |
Member
There was a problem hiding this comment.
One small thing here, rather than iterating over the bool array, I would pass them as argument.
Suggested change
| public async Task CustomSemanticSwatches_ExtractExpectedThemeColors() | |
| [Arguments(true)] | |
| [Arguments(false)] | |
| public async Task CustomSemanticSwatches_ExtractExpectedThemeColors(bool isDark) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
For a project I needed custom swatch colors derived from ISO 3864 colors:
- Error
- Warning (High & Low)
- Info
- Success
Content of the PR
This PR adds an unit tests that shows how to implement those custom swatches