fix: respect excludeProviders in API-level stream wrapper#4
Open
higorprado wants to merge 1 commit intoMasuRii:mainfrom
Open
fix: respect excludeProviders in API-level stream wrapper#4higorprado wants to merge 1 commit intoMasuRii:mainfrom
higorprado wants to merge 1 commit intoMasuRii:mainfrom
Conversation
Providers excluded via config were still intercepted at the API level because registerApiProvider registered a global stream handler for each API used by non-excluded providers. When an excluded provider (e.g. zai-glm) shared an API (e.g. anthropic-messages) with a managed provider but lacked its own streamSimple, requests fell through to the global wrapper which tried to rotate credentials for the unmanaged provider and failed. Pass the excludeProviders set to createRotatingStreamWrapper and delegate directly to the base API provider when the request originates from an excluded provider, bypassing credential rotation entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
excludeProviderswas only preventingpi.registerProvider()for excluded providers, but notregisterApiProvider()which registers a global stream handler per API.When an excluded provider shares an API with a managed provider and lacks its own
streamSimple, requests fall through to the global wrapper. The wrapper then tries to rotate credentials for the unmanaged provider and fails.Fix: pass the
excludeProvidersset tocreateRotatingStreamWrapper. When a request originates from an excluded provider, delegate directly to the base API provider — bypassing credential rotation entirely.Changes in
src/provider.ts:excludedProviders?: ReadonlySet<string>parameterexcludeSetfromregisterMultiAuthProvidersto the wrapperTypecheck, lint, and tests all pass (158/158).