add hmac verification for aes cbc #92
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseph-neeraj
requested changes
Dec 17, 2025
lib/mcapi/crypto/jwe-crypto.js
Outdated
Comment on lines
137
to
140
| secretKey = secretKey.slice(16, 32); | ||
| gcmMode = false; | ||
| if(this.enableHmacVerification) { | ||
| verifyCbcHmac(jweTokenParts[0], iv, encryptedText, authTag, secretKey); |
Contributor
There was a problem hiding this comment.
The secretKey is incorrect here I think, as it has already been sliced to be the encryption key. So the mac should be extracted and passed here. Something like:
Suggested change
| secretKey = secretKey.slice(16, 32); | |
| gcmMode = false; | |
| if(this.enableHmacVerification) { | |
| verifyCbcHmac(jweTokenParts[0], iv, encryptedText, authTag, secretKey); | |
| const macKey = secretKey.slice(0, 16); | |
| secretKey = secretKey.slice(16, 32); | |
| gcmMode = false; | |
| if(this.enableHmacVerification) { | |
| verifyCbcHmac(jweTokenParts[0], iv, encryptedText, authTag, macKey); |
joseph-neeraj
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
masterbranchDescription
This PR implements HMAC authentication tag verification for AES-CBC encrypted payloads (A128CBC-HS256) in JWE, providing enhanced security and compliance with RFC 7516 (JSON Web Encryption) specification. The feature is opt-in and disabled by default to maintain backward compatibility with existing systems.