Skip to content

WIP: fix: missing null and presence checks#7965

Open
YheChen wants to merge 1 commit into
MarkUsProject:masterfrom
YheChen:fix/missing-null-and-presence-checks
Open

WIP: fix: missing null and presence checks#7965
YheChen wants to merge 1 commit into
MarkUsProject:masterfrom
YheChen:fix/missing-null-and-presence-checks

Conversation

@YheChen
Copy link
Copy Markdown
Contributor

@YheChen YheChen commented May 27, 2026

Address the active_record_doctor missing_non_null_constraint and missing_presence_validation checks:

  • Add a migration setting NOT NULL on columns the models already treat as required (timestamps, belongs_to foreign keys, presence-validated columns).
  • Add presence/inclusion/exclusion validators to models for NOT NULL columns that lacked them. Booleans use inclusion: [true, false] and columns defaulting to "" / {} use exclusion: [nil].
  • Mark Annotation/AnnotationText belongs_to :creator as optional, since the column is nullified when a Role is destroyed.

Fix bugs surfaced by the new constraints:

  • Group creation flows were saving group_name as NULL before renaming.
  • Criterion/GradeEntryStudent randomly_assign_tas inserted rows with a null ta_id when given no TAs.

Proposed Changes

(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)

Screenshots of your changes (if applicable)
Associated documentation repository pull request (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

…ve_record_doctor

Address the active_record_doctor missing_non_null_constraint and
missing_presence_validation checks:

- Add a migration setting NOT NULL on columns the models already treat
  as required (timestamps, belongs_to foreign keys, presence-validated
  columns).
- Add presence/inclusion/exclusion validators to models for NOT NULL
  columns that lacked them. Booleans use inclusion: [true, false] and
  columns defaulting to "" / {} use exclusion: [nil].
- Mark Annotation/AnnotationText belongs_to :creator as optional, since
  the column is nullified when a Role is destroyed.

Fix bugs surfaced by the new constraints:
- Group creation flows were saving group_name as NULL before renaming.
- Criterion/GradeEntryStudent randomly_assign_tas inserted rows with a
  null ta_id when given no TAs.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant