WIP: fix: missing null and presence checks#7965
Open
YheChen wants to merge 1 commit into
Open
Conversation
…ve_record_doctor
Address the active_record_doctor missing_non_null_constraint and
missing_presence_validation checks:
- Add a migration setting NOT NULL on columns the models already treat
as required (timestamps, belongs_to foreign keys, presence-validated
columns).
- Add presence/inclusion/exclusion validators to models for NOT NULL
columns that lacked them. Booleans use inclusion: [true, false] and
columns defaulting to "" / {} use exclusion: [nil].
- Mark Annotation/AnnotationText belongs_to :creator as optional, since
the column is nullified when a Role is destroyed.
Fix bugs surfaced by the new constraints:
- Group creation flows were saving group_name as NULL before renaming.
- Criterion/GradeEntryStudent randomly_assign_tas inserted rows with a
null ta_id when given no TAs.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address the active_record_doctor missing_non_null_constraint and missing_presence_validation checks:
Fix bugs surfaced by the new constraints:
Proposed Changes
(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)
Screenshots of your changes (if applicable)
Associated documentation repository pull request (if applicable)
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)