Skip to content

Conversation

@Naragod
Copy link
Contributor

@Naragod Naragod commented Jan 13, 2026

Proposed Changes

When uploading grader-group mappings (via Graders -> Upload) without the Remove existing grader assignments option selected, a grader can be assigned to the same group multiple times. We wish to prevent this from happening by default.

Screenshots of your changes (if applicable)
Associated documentation repository pull request (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue) X
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@Naragod Naragod added this to the v2.9.1 milestone Jan 13, 2026
@Naragod Naragod changed the title ISSUE-7755: Remove adding duplicate graders on csv upload ISSUE-7755: Prevent adding duplicate graders on CSV upload Jan 13, 2026
@Naragod Naragod requested a review from donny-wong January 13, 2026 20:50
@Naragod Naragod marked this pull request as draft January 13, 2026 21:08
@coveralls
Copy link
Collaborator

coveralls commented Jan 13, 2026

Pull Request Test Coverage Report for Build 21273694870

Details

  • 36 of 36 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 91.648%

Totals Coverage Status
Change from base Build 21224303427: 0.006%
Covered Lines: 44331
Relevant Lines: 47563

💛 - Coveralls

@Naragod Naragod marked this pull request as ready for review January 14, 2026 19:34
@Naragod Naragod force-pushed the ISSUE-7755_remove_duplicate_insertion_of_csv_graders branch from e9bc7a2 to af293fb Compare January 19, 2026 15:06
Copy link
Contributor

@donny-wong donny-wong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Naragod , I left 1 comment.

@Naragod Naragod force-pushed the ISSUE-7755_remove_duplicate_insertion_of_csv_graders branch from af293fb to 29f84b8 Compare January 23, 2026 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Uploading graders through CSV allows for a grader to be assigned to a group multiple times

4 participants