Skip to content

MarkAxisa/movie-library

Folders and files

NameName
Last commit message
Last commit date

Latest commit

 

History

11 Commits
 
 
 
 
 
 
 
 
 
 
 
 
 
 

Repository files navigation

Overview

During the development of this application, I focused a lot on design.
To me, design in an application makes all the difference and is what defines a great app.
Most of the development time was spent working on the 'Carousel' component,
which makes up most of the UI. My goal was to create a simple yet attractive UI that is
easily scalable across different devices, and that is why I went with the Carousel approach.

Possible Improvements

ViewPort Resizing Approach

I would use an 'AppContext' in the APP component and rather than passing the prop
'isMobile' in every component I needed it, I would have it exposed throughout my entire application.

Proper Handling For Empty Results

Rather than simply closing the search widget and showing the user the regular lobby,
I could possibly dispatch a notification so as to make it clear to the user that no results were found.

Single Responsibility For App Component

I would decouple the search logic from the App component. The App component should be
nothing more than a shell component and should not contain any unrelated logic.
I would possibly move this logic inside the 'useSearch'

Better Component Structuring

Some components are to granular. An example of this is the 'CarouselButton' component.
This was created early on in the application and eventually I started splitting in a
more sensical way.

Proper Error Handling

I would implement proper error feedback whenever an error is returned from API rather
than just logging said error.

Mobile Styling Defect

When testing on the dev emulator, intermittently there seems to be some sort of overflow on the X-axis of the body,
even though I have overflow-x set to hidden. I tested it with multiple devices on which I could not replicate.
I tried investigating it but unfortunately I discovered It quite late.

About

No description, website, or topics provided.

Resources

Stars

Watchers

Forks

Releases

No releases published

Packages

 
 
 

Contributors