Skip to content

Attempt at fixing some of the errors reported by Sonatype Lift. #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Maritims wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Attempt at fixing some of the errors reported by Sonatype Lift. #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92298ba
Attempt at fixing some of the errors reported by Sonatype Lift.
Maritims Apr 26, 2022
e932311
Started using Path.toFile()
Maritims Apr 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,13 +112,24 @@
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.sonatype.plugins</groupId>
<artifactId>nexus-staging-maven-plugin</artifactId>
<version>1.6.7</version>
<extensions>true</extensions>
<configuration>
<serverId>ossrh</serverId>
<nexusUrl>https://s01.oss.sonatype.org/</nexusUrl>
<autoReleaseAfterClose>true</autoReleaseAfterClose>
</configuration>
</plugin>
</plugins>
</build>

<properties>
<maven.compiler.target>1.8</maven.compiler.target>
<maven.compiler.source>1.8</maven.compiler.source>
<maven.version>3.8.4</maven.version>
<maven.version>3.8.5</maven.version>
</properties>

<dependencies>
Expand Down Expand Up @@ -180,7 +191,7 @@
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId>
<version>4.4.0</version>
<version>4.5.1</version>
<scope>test</scope>
</dependency>
<!-- endregion -->
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/io/github/maritims/node/NodeWrapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,15 +131,15 @@ public boolean extract() {

String destinationDirectory;
try {
destinationDirectory = new File(nodeConfiguration.getExtractionDirectory().toString()).getCanonicalPath();
destinationDirectory = nodeConfiguration.getExtractionDirectory().toFile().getCanonicalPath();
} catch (IOException e) {
log.error("Unable to get canonical path for extraction destination", e);
return false;
}

while(tarEntry != null) {
Path path = Paths.get(destinationDirectory, tarEntry.getName());
File file = new File(path.toString());
File file = path.toFile();

if(tarEntry.isDirectory() && !file.exists() && !file.mkdirs()) {
log.error("Unable to create directory: " + path + ". Aborting.");
Expand Down