MDEV-39707 Assertion `lsn != 0' failed in log_write_up_to#5261
MDEV-39707 Assertion `lsn != 0' failed in log_write_up_to#5261Thirunarayanan wants to merge 1 commit into
Conversation
Problem: ======== innodb_make_page_dirty(): Unconditionally calls log_write_up_to() with mtr.commit_lsn() after committing the mini-transaction. When the mtr produced no redo records when the targeted page is full of zeroes. Solution: ======== innodb_make_page_dirty(): Skip log_write_up_to() when commit_lsn() is zero.
|
|
There was a problem hiding this comment.
Code Review
This pull request addresses the issue MDEV-39707 where an assertion lsn != 0 failed. In storage/innobase/handler/ha_innodb.cc, the call to log_write_up_to is now conditionally executed only when mtr.commit_lsn() returns a non-zero LSN. Additionally, a corresponding test case has been added to the InnoDB test suite to verify this behavior. I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Problem:
innodb_make_page_dirty(): Unconditionally calls log_write_up_to() with mtr.commit_lsn() after committing the mini-transaction. When the mtr produced no redo records when the targeted page is full of zeroes.
Solution:
innodb_make_page_dirty(): Skip log_write_up_to() when commit_lsn() is zero.