Skip to content

MDEV-39707 Assertion `lsn != 0' failed in log_write_up_to#5261

Open
Thirunarayanan wants to merge 1 commit into
10.11from
MDEV-39707
Open

MDEV-39707 Assertion `lsn != 0' failed in log_write_up_to#5261
Thirunarayanan wants to merge 1 commit into
10.11from
MDEV-39707

Conversation

@Thirunarayanan

Copy link
Copy Markdown
Member

Problem:

innodb_make_page_dirty(): Unconditionally calls log_write_up_to() with mtr.commit_lsn() after committing the mini-transaction. When the mtr produced no redo records when the targeted page is full of zeroes.

Solution:

innodb_make_page_dirty(): Skip log_write_up_to() when commit_lsn() is zero.

Problem:
========
innodb_make_page_dirty(): Unconditionally calls log_write_up_to()
with mtr.commit_lsn() after committing the mini-transaction.
When the mtr produced no redo records when the targeted page
is full of zeroes.

Solution:
========
innodb_make_page_dirty(): Skip log_write_up_to() when
commit_lsn() is zero.
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses the issue MDEV-39707 where an assertion lsn != 0 failed. In storage/innobase/handler/ha_innodb.cc, the call to log_write_up_to is now conditionally executed only when mtr.commit_lsn() returns a non-zero LSN. Additionally, a corresponding test case has been added to the InnoDB test suite to verify this behavior. I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants