Skip to content

MDEV-29909 : SST fails when table is defined with DATA DIRECTORY='/pa… #5226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
janlindstrom wants to merge 1 commit into
base: main
Choose a base branch
from
Open

MDEV-29909 : SST fails when table is defined with DATA DIRECTORY='/pa… #5226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 28 additions & 10 deletions sql/wsrep_sst.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,10 @@
#include <cstdlib>
#include "debug_sync.h"
#include "my_rnd.h"
#include <filesystem>

#ifdef HAVE_SYS_STATVFS_H
#include <sys/statvfs.h>
#endif

#include <my_service_manager.h>

Expand Down Expand Up @@ -657,23 +660,38 @@ static bool sst_report_progress(const bool joiner,
const char *path = (wsrep_sst_tmp_dir_real && strlen(wsrep_sst_tmp_dir_real) != 0) ?
wsrep_sst_tmp_dir_real : mysql_real_data_home_ptr;

const std::filesystem::path p(path);
std::error_code ec;
std::filesystem::space_info si = std::filesystem::space(p, ec);
constexpr std::uintmax_t failed(-1);
if (si.available == failed)
si.available= 0;
/* Determine available space on the target filesystem. On any failure
(or on platforms without statvfs) available stays 0, which keeps the
original fail-closed behaviour of aborting the SST. */
unsigned long long available= 0;
#ifdef HAVE_SYS_STATVFS_H
struct statvfs si;
if (statvfs(path, &si) == 0)
{
if (si.f_frsize == 0)
available= (unsigned long long) si.f_bavail;
else
available= (unsigned long long) si.f_bavail * si.f_frsize;
}
else
{
WSREP_INFO("Failed to determine available space in path %s, errno %d",
path, errno);
}
#else
WSREP_INFO("Can't determine available space in path %s", path);
#endif /* HAVE_SYS_STATVFS_H */

const unsigned long long requested= total + total_prev;

WSREP_INFO("Requested total size %llu space available %llu in path %s",
total, (unsigned long long)si.available, path);
total, available, path);

if (requested >= si.available)
if (requested >= available)
{
WSREP_ERROR("Target path %s does not have enough available space for"
" SST data available: %llu bytes < requested total %llu bytes ",
path, (unsigned long long)si.available, requested);
path, available, requested);
return true;
}
}
Expand Down
Loading