MDEV-38180: Add xxh32(), xxh3(), and xxh3_128() SQL functions#4741
Open
monthdev wants to merge 3 commits intoMariaDB:mainfrom
Open
MDEV-38180: Add xxh32(), xxh3(), and xxh3_128() SQL functions#4741monthdev wants to merge 3 commits intoMariaDB:mainfrom
monthdev wants to merge 3 commits intoMariaDB:mainfrom
Conversation
|
|
gkodinov
added
the
External Contribution
gkodinov
requested changes
Mar 6, 2026
Member
gkodinov
left a comment
gkodinov
left a comment
There was a problem hiding this comment.
This is a preliminary review. Thank you for your contribution.
I think you need to figure out what is the fate of the other PR. As yours seems to mostly be a fork of it (I didn't compare, but it looks very similar). I will add Daniel as a reviewer to this one so he can work on that.
Should we decide to go ahead, please make sure your commit message must be present and must follow CODING_STANDARDS.md
Merge with main
monthdev
changed the title
Author
|
@gkodinov I appreciate the review! In my latest commit, I
Please let me know of any other problems or nits! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address MDEV-38180.
There is already an open PR for this here #4500. I am just assuming it was dropped and reiterating with a narrower scope.